Closed Bug 496409 Opened 11 years ago Closed 11 years ago

Change value of the en-US Yahoo! search plugin fr code for Firefox 3.5

Categories

(Firefox :: Search, defect, major)

3.5 Branch
defect
Not set
major

Tracking

()

RESOLVED FIXED
Firefox 3.5

People

(Reporter: kev, Unassigned)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 2 obsolete files)

Per the terms of the agreement with Yahoo! Corp., the fr code in the default Yahoo! search plugin for en-US must be changed to "moz35" for the release of 3.5 (other locales will follow suit in an upcoming point release, and a separate bug (or bugs) will be filed. 

patch attached for /other-licenses/branding/firefox/pref/firefox-branding.js , please let me know if there are questions.

kev
Flags: blocking-firefox3.5?
Attachment #381585 - Flags: review?(beltzner)
Version: unspecified → 3.5 Branch
Attachment #381585 - Flags: review?(beltzner) → review-
Comment on attachment 381585 [details] [diff] [review]
change fr code in Yahoo! search plugin 

I think we should just change -fr only at this time; we can get the other changes when we do the rest of the locales.
concur. en-US only makes use of the yahoo-fr param/pref in the plugin, so your rationale makes sense.
Attachment #381585 - Attachment is obsolete: true
Attachment #381631 - Flags: review?(beltzner)
Comment on attachment 381585 [details] [diff] [review]
change fr code in Yahoo! search plugin 

I misunderstood, and managed to confuse Kev. This is the right patch. All the parameters for Firefox 3.5 should be "moz35". Locales might need to change their searchplugins to be locale-specific, but that's something we can do after.

Apologies for churn.
Attachment #381585 - Flags: review- → review+
Attachment #381631 - Attachment is obsolete: true
Attachment #381631 - Flags: review?(beltzner)
Attachment #381585 - Attachment is obsolete: false
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Keywords: checkin-needed
Whiteboard: [can land]
removing "browser.search.param.yahoo-f-CN", as it is no longer used in the product.
Attachment #381585 - Attachment is obsolete: true
Attachment #381639 - Flags: review?(beltzner)
Attachment #381639 - Flags: review?(beltzner) → review+
Does this need to land on m-c too, or just 1.9.1 branch?
It should land on m-c as well, unless the value should be different for post-3.5 versions... :)
Pushed http://hg.mozilla.org/mozilla-central/rev/976839f0b364
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.