496409 - Change value of the en-US Yahoo! search plugin fr code for Firefox 3.5

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Kev Needham [:kev]]

Attachment: change fr code in Yahoo! search plugin

Per the terms of the agreement with Yahoo! Corp., the fr code in the default Yahoo! search plugin for en-US must be changed to "moz35" for the release of 3.5 (other locales will follow suit in an upcoming point release, and a separate bug (or bugs) will be filed. 

patch attached for /other-licenses/branding/firefox/pref/firefox-branding.js , please let me know if there are questions.

kev

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 381585 [details] [diff] [review]
change fr code in Yahoo! search plugin 

I think we should just change -fr only at this time; we can get the other changes when we do the rest of the locales.

Comment 2

[Kev Needham [:kev]]

Attachment: revied change to affect fr code in en-US only

concur. en-US only makes use of the yahoo-fr param/pref in the plugin, so your rationale makes sense.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 381585 [details] [diff] [review]
change fr code in Yahoo! search plugin 

I misunderstood, and managed to confuse Kev. This is the right patch. All the parameters for Firefox 3.5 should be "moz35". Locales might need to change their searchplugins to be locale-specific, but that's something we can do after.

Apologies for churn.

Comment 4

[Kev Needham [:kev]]

Attachment: change fr code in Yahoo! search plugin (updated)

removing "browser.search.param.yahoo-f-CN", as it is no longer used in the product.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Does this need to land on m-c too, or just 1.9.1 branch?

Comment 6

[Mike Connor [:mconnor]]

It should land on m-c as well, unless the value should be different for post-3.5 versions... :)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/976839f0b364

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/010761f9d36b