496417 - Long strings in the promo box can run into the bottom selector/border area

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Using Shiretoko on Mac OS X 10.5, and loading the Greek version of AMO, https://preview.addons.mozilla.org/el/firefox/, the promo-type links can run into the bottom selector; hard to describe--see the screenshot.

Comment 1

[Dave Garrett]

You mean the "Σας αρέσουν; Βρείτε κι άλλα πρόσθετα στη σελίδα Family Organizer." line? ("Like these? Find related add-ons in the Family Organizer collection." in English) I can get it rather easily if the content of the box is too big in any locale.

Also see bug 496469.

Comment 2

[Fred Wenzel [:wenzel]]

Yes, surprise!, some of the German promo panes have the same problem.

Comment 3

[Ryan Doherty (:rdoherty)]

There's simply not enough room for some locale's strings, even with no padding between the items. If it's at all possible, we need to have the locales attempt to reduce their content.

Also, the text was changed about a week ago, so some of the translations could be old. The new en-US translations are much shorter.

Comment 4

[Ryan Doherty (:rdoherty)]

Attachment: Greek with no padding

Here's Greek with no padding and max window width.

Comment 5

[Fred Wenzel [:wenzel]]

I hope that's not too naive a question, but what about letting the promo box grow vertically with its content?

Comment 6

[Ryan Doherty (:rdoherty)]

Attachment: v1

Simple fix!

Comment 7

[Ryan Doherty (:rdoherty)]

(In reply to comment #5)
> I hope that's not too naive a question, but what about letting the promo box
> grow vertically with its content?

Yeah, that's pretty much what I did by removing the position:absolute stuff for the navigation. Moving it below the main content area allowed it to expand and push down the content instead of overlapping.

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 381808 [details] [diff] [review]
v1

The indicator arrow looks weird but at least it works.  If that's as good as it gets, r+.  Thanks.

Comment 9

[Fred Wenzel [:wenzel]]

Comment on attachment 381808 [details] [diff] [review]
v1

I tried it out and it works for me too.

Double r+ for the win!

Comment 10

[Ryan Doherty (:rdoherty)]

r27248

Thanks guys!

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/el/firefox/.