49646 - C style casts that should probably be using C++ casts?

Status: VERIFIED INVALID

(Core Graveyard :: Security: UI, defect, P3)

Description

[Bruce Mitchener]

From current CVS (HP ports tinderbox):

Warning 749: "nsCrypto.cpp", line 214 # The cast from 'nsIScriptGlobalObject *' 
to 'nsISupports *' is performed as a 'reinterpret_cast'. This operation is 
non-portable and potentially unsafe.
                                        (nsISupports *)global, 
                                        ^^^^^^^^^^^^^^^        

Warning 749: "nsCrypto.cpp", line 1216 # The cast from 'nsIScriptGlobalObject *' 
to 'nsISupports *' is performed as a 'reinterpret_cast'. This operation is 
non-portable and potentially unsafe.
                                    (nsISupports *)global, 
(void**)&mScriptObject);
                                    ^^^^^^^^^^^^^^^                             
   
Warning 749: "nsCrypto.cpp", line 1407 # The cast from 'nsIScriptGlobalObject *' 
to 'nsISupports *' is performed as a 'reinterpret_cast'. This operation is 
non-portable and potentially unsafe.
                                    (nsISupports *)global, 
(void**)&mScriptObject);
                                    ^^^^^^^^^^^^^^^

Comment 1

[John Unruh]

Changing QA contact to nitinp

Comment 2

[John Unruh]

Mass reassigning nitinp's bugs to me.

Comment 3

[John Unruh]

Bruce Mitchener, any change in status with this bug?

Comment 4

[John Unruh]

Resolving invalid, since there has been no feed back on this bug for 8 months.

Comment 5

[Bruce Mitchener]

If the invalid casts are still in the code (and I don't know that they are, I'm
too busy to do much on Mozilla these months), then there's no reason to close
out this bug unless these types of bugs are deemed to be unworthy of the effort
to fix them.

Comment 6

[John G. Myers]

With the PSM2 landing, the file nsCrypto.cpp is no longer in the build.

Comment 7

[John Unruh]

Verified.