C style casts that should probably be using C++ casts?

VERIFIED INVALID

Status

Core Graveyard
Security: UI
P3
normal
VERIFIED INVALID
17 years ago
a year ago

People

(Reporter: Bruce Mitchener, Assigned: David P. Drinan)

Tracking

Other Branch

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

17 years ago
From current CVS (HP ports tinderbox):

Warning 749: "nsCrypto.cpp", line 214 # The cast from 'nsIScriptGlobalObject *' 
to 'nsISupports *' is performed as a 'reinterpret_cast'. This operation is 
non-portable and potentially unsafe.
                                        (nsISupports *)global, 
                                        ^^^^^^^^^^^^^^^        

Warning 749: "nsCrypto.cpp", line 1216 # The cast from 'nsIScriptGlobalObject *' 
to 'nsISupports *' is performed as a 'reinterpret_cast'. This operation is 
non-portable and potentially unsafe.
                                    (nsISupports *)global, 
(void**)&mScriptObject);
                                    ^^^^^^^^^^^^^^^                             
   
Warning 749: "nsCrypto.cpp", line 1407 # The cast from 'nsIScriptGlobalObject *' 
to 'nsISupports *' is performed as a 'reinterpret_cast'. This operation is 
non-portable and potentially unsafe.
                                    (nsISupports *)global, 
(void**)&mScriptObject);
                                    ^^^^^^^^^^^^^^^

Comment 1

17 years ago
Changing QA contact to nitinp
QA Contact: junruh → nitinp

Comment 2

17 years ago
Mass reassigning nitinp's bugs to me.
QA Contact: nitinp → junruh

Comment 3

17 years ago
Bruce Mitchener, any change in status with this bug?

Comment 4

17 years ago
Resolving invalid, since there has been no feed back on this bug for 8 months.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → INVALID
(Reporter)

Comment 5

17 years ago
If the invalid casts are still in the code (and I don't know that they are, I'm
too busy to do much on Mozilla these months), then there's no reason to close
out this bug unless these types of bugs are deemed to be unworthy of the effort
to fix them.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Comment 6

17 years ago
With the PSM2 landing, the file nsCrypto.cpp is no longer in the build.
Status: REOPENED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → INVALID

Comment 7

17 years ago
Verified.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.