496618 - The back/forward buttons in Firefox 3.5 are buggy with 1.2 RC1

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Flore Allemandou [:flore]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fr; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fr; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4

With the personas 1.2RC1, the back/forward buttons are incorrectly displayed, i.e. there seems to be a part of another button on the right side (with large or small icos, the problem is the same).

Reproducible: Always

Steps to Reproduce:
1. Install personas 1.2RC1 on Firefox 3.5b4 on Mac
2. The back/forward buttons is not correctly displayed


Expected Results:  
The button should be the same size and aspect as without personas.

Comment 1

[Flore Allemandou [:flore]]

Attachment: back/forward buttons incorrectly displayed

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I see this too on Firefox 3.5b4, although I don't see it on the latest nightly.  I suspect that this is because the fix we made to make Personas work with the recent changes to the Firefox 3.5 back/forward buttons regresses their appearance on Firefox 3.5 builds with the old-style buttons.

I bet there's a way to fix this, so we don't hork all the users on 3.5b4.  I think we just need to include the -moz-image-region rules for the buttons in the Personas skin for Mac.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Fixed <http://hg.mozilla.org/labs/personas/rev/49788d212ce2> and pushed development build with fix <http://people.mozilla.com/~cbeard/personas/dist/personas-dev.xpi>.

I fixed this, per comment 2, by including the -moz-image-region rules for the core toolbar buttons in the Personas skin for Firefox 3.5 on Mac OS X.

As a side effect, this may improve Personas compatibility with third-party themes that specify their own toolbarbutton icon, since Personas might still override them, but at least when it does so it'll override both the image file and the region within the image where the icon is to be found.

Comment 4

[Flore Allemandou [:flore]]

That's OK for me.
Thanks Myk

Comment 6

[Carsten Book [:Tomcat]]

verified fixed