This is something important that was left out of the Clearleft mocks and I didn't notice until now. It will have to wait until 5.0.7 though. :( In the collection view, if an add-on has publisher comments associated with it, they should be displayed there. Assigning to myself to attach a mockup.
Created attachment 382007 [details] [diff] [review] patch, v1 After thinking about it more, I think this blocks 5.0.6. I should have caught this earlier when it wasn't in Clearleft's mocks. It was in the wireframe we gave them (attachment 367634 [details]). Since it's my fault, I made a patch. It re-uses the review string so doesn't require l10n changes.
Attachment #382007 - Flags: review?(clouserw)
Priority: -- → P1
Target Milestone: 5.0.7 → 5.0.6
Attachment #382007 - Flags: review?(clouserw) → review+
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
A query that won't get cached (if I understand our caching correctly) in a loop?
Stephen, for an example of a collection using these comments, see https://preview.addons.mozilla.org/en-US/firefox/collection/twittertracker (please don't make any changes to that one - I'm using it in my screencasts :) )
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/collection/twittertracker; thanks, Fligtar (no worries, won't touch it).
Status: RESOLVED → VERIFIED
(In reply to comment #4) > A query that won't get cached (if I understand our caching correctly) in a > loop? Why won't it?
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.