496775 - All tabs icon is slightly misaligned

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

(In reply to bug 495218 comment #50)
> It now feels as if 2px of the button were cut off...
> (in attachment 381007 [details] you'll notice that the original
> arrow was centered while the new one isn't).

The button is 18px wide, but should be 17px, so that the icon (13px) can be centered.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

this should do it

Comment 2

[Dão Gottwald [:dao]]

Attachment: screenshot with patch

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 382005 [details] [diff] [review]
patch

Sorry for the delay; had a little review-mail fail for some reason.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 382005 [details] [diff] [review]
patch

Let's let this bake on trunk, first; want to make sure changing these widths doesn't mess up the tabstrip animation stuff (yes, I'm being paranoid!)

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 382005 [details] [diff] [review]
patch

a191=beltzner

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/c1bb1dfd7a15

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.

Comment 8

[Aakash Desai [:aakashd]]

verified FIXED on Shiretoko:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090629 Shiretoko/3.5pre