496854 - Restrict icon size in auto-complete dropdown

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P4)

Description

[Justin Scott [:fligtar]]

When using the add-on auto-completer to add add-ons to a collection in both creating and editing collections, custom icons are small but the default icon is normal sized.

Comment 1

[Fred Wenzel [:wenzel]]

Uhm, thanks for assigning this to me, Wil, but is this even a website bug? If so, I need more information (like a link), please, Fligtar.

Comment 2

[Justin Scott [:fligtar]]

I investigated further, and it looks like there are some add-ons like Ubiquity for example that have icons smaller than 32x32. On add-on display pages and elsewhere we force the icons to be 32x32 but in the auto-completer we don't.

Comment 3

[Wil Clouser [:clouserw]]

We should force everything to 32x32

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Patch, rev. 1

Simple CSS fix.

Comment 5

[Fred Wenzel [:wenzel]]

r28255, thanks!

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

So, just to be certain; even though this looks bad, this is OK because it's that Ubiquity's icon, which is smaller than 32x32, is up-scaled to be 32x32, and they need to upload a 32x32 icon to look good, right?

Comment 7

[Wil Clouser [:clouserw]]

Yep

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

K -- verified FIXED, then (checked preview vs. prod).