496860 - sed: command garbled for SOURCE_REPO

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ginn Chen]

The patch should be applied for mail, suite, calender.

+++ This bug was initially created as a clone of Bug #479762 +++

In browser/app, run make on Solaris 10
Got sed: command garbled error in terminal.

I found similar code in toolkit/xre/Makefile.in and toolkit/content/Makefile.in.
Should we copy it to browser/app/Makefile.in?

+# strip a trailing slash from the repo URL because it's not always present,
+# and we want to construct a working URL in buildconfig.html
+# make+shell+sed = awful
+_dollar=$$
+SOURCE_REPO := $(shell cd $(topsrcdir) && hg showconfig paths.default 2>/dev/null | head -n1 | sed -e "s/^ssh:/http:/" -e "s/\/$(_dollar)//" )
+

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Mark Banner (:standard8)]

FYI we normally put "comm-central" build config bugs under mailnews core (even though that isn't as "global" as it could be.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 382098 [details] [diff] [review]
patch

I'm sure Ted would be happy to review this, but no need to increase his load with comm-central changes.

r=Standard8

Comment 4

[Ginn Chen]

http://hg.mozilla.org/comm-central/rev/09ce039b6d12