sed: command garbled for SOURCE_REPO

RESOLVED FIXED

Status

MailNews Core
Build Config
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Trunk
All
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
The patch should be applied for mail, suite, calender.

+++ This bug was initially created as a clone of Bug #479762 +++

In browser/app, run make on Solaris 10
Got sed: command garbled error in terminal.

I found similar code in toolkit/xre/Makefile.in and toolkit/content/Makefile.in.
Should we copy it to browser/app/Makefile.in?

+# strip a trailing slash from the repo URL because it's not always present,
+# and we want to construct a working URL in buildconfig.html
+# make+shell+sed = awful
+_dollar=$$
+SOURCE_REPO := $(shell cd $(topsrcdir) && hg showconfig paths.default 2>/dev/null | head -n1 | sed -e "s/^ssh:/http:/" -e "s/\/$(_dollar)//" )
+
(Assignee)

Comment 1

9 years ago
Created attachment 382098 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #382098 - Flags: review?(ted.mielczarek)
FYI we normally put "comm-central" build config bugs under mailnews core (even though that isn't as "global" as it could be.
Component: Build Config → Build Config
Product: Thunderbird → MailNews Core
QA Contact: build-config → build-config
Comment on attachment 382098 [details] [diff] [review]
patch

I'm sure Ted would be happy to review this, but no need to increase his load with comm-central changes.

r=Standard8
Attachment #382098 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/comm-central/rev/09ce039b6d12
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.