Closed Bug 496884 Opened 12 years ago Closed 11 years ago

Collapsed summary view header hides message summary for threads with long subjects

Categories

(Thunderbird :: Message Reader UI, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: standard8, Assigned: davida)

References

(Blocks 1 open bug)

Details

(Whiteboard: [no l10n impact])

Attachments

(2 files, 1 obsolete file)

STR:

1) Get a message thread which has a very long subject line.
2) View collapsed thread on that message thread.
3) Find you can't read the summary of the message.
4) Make Thunderbird narrower, find it is even worse.

Best explained by a picture. Note the lack of scrollbars or anything.
Flags: blocking-thunderbird3+
Since this is not a regression, I don't think we'd hold b3 for this.  Retargetting to b4.
Target Milestone: Thunderbird 3.0b3 → Thunderbird 3.0b4
Whiteboard: [no l10n impact]
Attached patch the fix (obsolete) — Splinter Review
You complain, you get to review the fix.
Attachment #398498 - Flags: review?(bugzilla)
Whiteboard: [no l10n impact] → [no l10n impact][has patch, needs review standard8]
Comment on attachment 398498 [details] [diff] [review]
the fix

The contentDocument/defaultView doesn't get destroyed and recreated each time we show something different in the summary pane.

Hence this adds more listeners every time we show the summary view.
Attachment #398498 - Flags: review?(bugzilla) → review-
Oh, and the line within the function should be two-space indented.
Whiteboard: [no l10n impact][has patch, needs review standard8] → [no l10n impact][needs new patch]
Attached patch patch v2Splinter Review
nice catch.  how's this?  (in general, i don't like inline JS in HTML, but creating a whole new file & make patch just for this seemed overkill)
Attachment #398498 - Attachment is obsolete: true
Attachment #398683 - Flags: review?(bugzilla)
Whiteboard: [no l10n impact][needs new patch] → [no l10n impact][has patch, needs review standard8]
Attachment #398683 - Flags: review?(bugzilla) → review+
Comment on attachment 398683 [details] [diff] [review]
patch v2

That's better. r=Standard8.

I've checked this in as well:

http://hg.mozilla.org/comm-central/rev/478bce596df0
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [no l10n impact][has patch, needs review standard8] → [no l10n impact]
You need to log in before you can comment on or make changes to this bug.