496980 - Affiliates button HTML is broken

Status: VERIFIED FIXED

Description

[Alex Buchanan [:abuchanan]]

The affiliate button HTML is broken.  Per a "Contact Us" email...

I would like to point out that there is a HTML nesting error in the code generated for affiliate links.

Example: <a href='http://www.mozilla.com/?from=sfx&uid=263197&t=329'><img src='http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/120x240.png' alt='Spread Firefox Affiliate Button' border=0 /></img>

Should read: <a href='http://www.mozilla.com/?from=sfx&uid=263197&t=329'><img src='http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/120x240.png' alt='Spread Firefox Affiliate Button' border="0" /></a>

The closing tag is for the <a> tag and not the <img> tag as that's already closed using  />. The border=0 should have the 0 enclosed in either single or double quotation marks, ie. border="0"

Comment 1

[Alex Buchanan [:abuchanan]]

r27379 checks in a fix to trunk

Comment 2

[Alex Buchanan [:abuchanan]]

r27382 checks in a better fix

Comment 3

[Alex Buchanan [:abuchanan]]

this looks fixed on stage

https://spreadfirefox.authstage.mozilla.com/?q=affiliates/get_button&button=3

donner, could you verify?  I'd like to get this fix pushed asap. Thanks.

Comment 4

[Stephen Donner [:stephend]]

(In reply to comment #3)
> this looks fixed on stage
> 
> https://spreadfirefox.authstage.mozilla.com/?q=affiliates/get_button&button=3
> 
> donner, could you verify?  I'd like to get this fix pushed asap. Thanks.

Looks good to me!

Comment 5

[Alex Buchanan [:abuchanan]]

r27391 tags this fix for production.

Over to IT to svn up production for Spreadfirefox.com please.

This is a regression and a 1 line fix, so making it a blocker so it gets done tonight.

Thanks guys!

Comment 6

[Jeremy Orem [:oremj]]

U    sites/all/modules/sfx_affiliates/sfx_affiliates.module
 U   sites/all/modules/sfx_affiliates
Updated to revision 27394.

Comment 7

[Stephen Donner [:stephend]]

Verified FIXED on prod:

<a href='http://www.mozilla.com/?from=sfx&amp;uid=0&amp;t=305'><img src='http://sfx-images.mozilla.org/affiliates/Buttons/firefox3/110x32_best-yet.png' alt='Spread Firefox Affiliate Button' border='0' /></a>