Closed Bug 497089 Opened 15 years ago Closed 15 years ago

When tests finish, free various message headers/global variables.

Categories

(MailNews Core :: Backend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
When running with the patch on bug 438922 I see various leaks in the unit tests of the form:

== BloatView: ALL (cumulative) LEAK STATISTICS

     |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Rem      Mean       StdDev     Total      Rem      Mean       StdDev
   0 TOTAL                                          26      100     7755        2 (   82.40 +/-    85.76)    19135        2 (   77.76 +/-    76.83)
  28 morkObject                                     44       44       67        1 (   20.65 +/-     9.46)      202        1 (   31.86 +/-    13.73)
  29 morkRowObject                                  56       56       11        1 (    5.38 +/-     2.64)       17        1 (    5.18 +/-     2.31)

I tracked this down to the fact that we're holding onto message headers in global variables. For some reason without the patch for bug 438922 we don't see these in the list, but I expect that is because there are various things being "hidden".

The patch attached fixes most of these. Once we actually land bug 438922 we can look at fixing the harder ones.
Attachment #382283 - Flags: review?(bienvenu)
Attachment #382283 - Flags: review?(bienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/d1a9b79cf5c2
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: