js1_5/extensions/regress-424942.js shell linux so far. Assertion failure: (int16) JSVAL_TO_INT(id) == JSVAL_TO_INT(id), at ../jsfun.cpp:1071
Assignee: general → brendan
Status: NEW → ASSIGNED
Priority: -- → P1
Hardware: x86 → All
Target Milestone: --- → mozilla1.9.1
Created attachment 382552 [details] [diff] [review] fix the assertbotch This is a debug-only assertion botch, the non-DEBUG code does the right thing. /be
Attachment #382552 - Flags: review?(igor)
Debug-only assertion is not a blocker, but is still welcome.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Comment on attachment 382552 [details] [diff] [review] fix the assertbotch >diff --git a/js/src/jsfun.cpp b/js/src/jsfun.cpp >@@ -1207,7 +1207,7 @@ call_resolve(JSContext *cx, JSObject *ob >+ if (!CallPropertyOp(cx, obj, INT_TO_JSID((int16)slot), &v, JSCPK_VAR, JS_FALSE)) Nit: use int16(slot).
Nearby cast used C style, of course (since the code was written in 1.9 era) and the assertion does too. I'll clean up on trunk in another bug, opportunistically. Thanks, /be
v 1.9.1, 1.9.2 on mac intel.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.