497187 - Mobile: Features

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Ryan Doherty (:rdoherty)]

Tracking creating of desktop Fennec features page.

Comment 1

[Ryan Doherty (:rdoherty)]

Attachment: v1

First stab at features page. Will attach zip of new images.

Comment 2

[Ryan Doherty (:rdoherty)]

Attachment: new images

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Comment on attachment 383530 [details] [diff] [review]
v1

Let's take out the xxMB altogether since we actually won't know the download size since we won't know what device they are using.

additionally the download link should be:
"/<?php echo $lang ?>/mobile/"

Comment 4

[Reed Loden [:reed]]

(In reply to comment #3)
> additionally the download link should be:
> "/<?php echo $lang ?>/mobile/"

I prefer <?=$lang?>, so please use that instead of echo.

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: v2

New patch with fixes.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

reed-
my issue with short tags is that they aren't compatible with all php instances.  While it's not a huge problem in a controlled environment (we control all the servers), it makes an unnecessary requirement for others who want to hack on our code.

-d

Comment 7

[Reed Loden [:reed]]

We use short tags everywhere throughout the www.mozilla.com code, so I'd like to keep the code consistent. If this was the only use of short tags, I could understand, but it's not, so I'd like to continue using them.

Comment 8

[Michael Morgan [:morgamic]]

Both are valid -- it's not a big deal either way.

Comment 9

[Ryan Doherty (:rdoherty)]

r28276

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

To keep this clean, I'm QA'ing this over in 499873.