Closed
Bug 497190
Opened 16 years ago
Closed 16 years ago
Mobile: System Requirements
Categories
(www.mozilla.org :: General, defect)
www.mozilla.org
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rdoherty, Assigned: davedash)
References
()
Details
Attachments
(1 file)
|
6.78 KB,
patch
|
rdoherty
:
review+
|
Details | Diff | Splinter Review |
Tracking creating of desktop Fennec system requirements page.
| Assignee | ||
Comment 1•16 years ago
|
||
Added submenu everywhere in addition to adding this page. Also turned the downloady widget into an include.
Attachment #384948 -
Flags: review?(rdoherty)
| Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
| Reporter | ||
Updated•16 years ago
|
Attachment #384948 -
Flags: review?(rdoherty) → review+
| Reporter | ||
Comment 2•16 years ago
|
||
Comment on attachment 384948 [details] [diff] [review]
v1
Page looks mostly ok, just a few minor issues.
I see a mozilla-expanders.css & animation-min.js added to the head of the page, but not used, are they necessary?
The font sizing is a little off compared to the PSD, but the only size I think should be changed is the 'Fennec System Requirements' header. It should match the mozilla.com font size for consistency.
I'm ok with the patch if those 2 issues are fixed.
| Assignee | ||
Comment 3•16 years ago
|
||
Yes, you are right, I was being lazy with the JS.
Ah - I think I did screw up the fonts, but I fixed it in another branch - I know exactly what you're talking about.
Will fix and commit upstream.
| Assignee | ||
Comment 4•16 years ago
|
||
awesomepants:~/Projects/Fennec/mozilla.com % git svn dcommit
Committing to https://svn.mozilla.org/projects/mozilla.com/trunk ...
M includes/functions.inc.php
Committed r28574
M includes/functions.inc.php
r28574 = 9823cc09e963cabf29f4b14e1a2efb6db8e6fc5b (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/faq.html: locally modified
en-US/mobile/features.html: locally modified
en-US/mobile/index.html: locally modified
style/tignish/mobile.css: locally modified
M en-US/mobile/faq.html
M en-US/mobile/features.html
A en-US/mobile/include/download.inc
A en-US/mobile/requirements.html
M style/tignish/mobile.css
Committed r28575
M en-US/mobile/features.html
A en-US/mobile/include/download.inc
A en-US/mobile/requirements.html
M en-US/mobile/faq.html
M style/tignish/mobile.css
r28575 = b8ce011b385fe0fa6a89b5343da263752619bfab (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
en-US/mobile/index.html: locally modified
style/tignish/mobile.css: locally modified
M en-US/mobile/index.html
M style/tignish/mobile.css
Committed r28576
M en-US/mobile/index.html
M style/tignish/mobile.css
r28576 = f59ecfa9e8d49023df50a73db915157b47feb114 (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•16 years ago
|
||
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Updated•13 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in
before you can comment on or make changes to this bug.
Description
•