497305 - Auto-complete popup for extensions doesn't allow scrolling

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When you wanna add new extensions to your collection and enter search terms like "extension" or "firefox" you will get a list of extensions which will cause a scroll bar to appear. When you use the arrow keys to move down the list it will only work for the first 5 entries. Further keypresses don't cause a scrolling. So you will not be able to select such an extension by keyboard. A mouse has to be used.

It should be keyboard accessible. :)

Comment 1

[Fred Wenzel [:wenzel]]

Not sure if the "major" severity is warranted, but I can confirm the bug: Scrolling is only possible with the mouse.

There's probably some JS missing (or broken?) here. We should compare it to the same feature on the admin pages. If it works there, we can reuse the code, if not, we should fix it there too.

Comment 2

[u278084]

Attachment: using the keyboard with latest plugin

(In reply to comment #1)
> There's probably some JS missing (or broken?) here. We should compare it to the
> same feature on the admin pages. If it works there, we can reuse the code, if
> not, we should fix it there too.

We seem to be using the same JS code for both pages. Digging in a little deeper, it looks like the next version of the auto-complete code somewhat fixes this problem for us (it looks like we are using http://plugins.jquery.com/project/autocompletex for our auto-complete plugin). I attached a screenshot looking at the last result. While it does scroll, it clips the icon a bit.

Comment 3

[u278084]

Committed in r28340. I checked the Admin's add-on manager, collections, and editor filter. All work as expected locally.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I filed 500296 as a spinoff (a limitation of the plugin, probably).