49741 - Eliminate failovers in generated idi

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P1)

Description

[Samir Gehani]

Rearchitecting the failover mechanism entails:

1> Download a redirect.ini
	i>   Domain from site selector
	ii>  Server path from redirect section

2> Parse redirect for the domain matching the index of the selected site.

3> Generate one URL per xpi in idi for SmartDownload to use. 
	If redirect.ini found and parsed successfully:
		Append xpi names to the redirect.ini's domain-specific global URL.
	Else if no redirect.ini or parse failed:
		Append xpi names to the global URL in the config.ini.

* This eliminates failovers.
* This allows flexibility for editing the redirect.ini on a per server basis.
* This reduces errors when matching localized site names in the config.ini with
  those in the rdirect.ini.

Comment 1

[Jeffrey Baker]

49472 has fewer typos.

*** This bug has been marked as a duplicate of 49472 ***

Comment 2

[Samir Gehani]

This is not a duplicate.  This is the Mac bug while bug 49742 is the Windows
bug.  Thanks for the lending hand though.  

Comment 3

[Daniel Veditz [:dveditz] out until Nov 10]

Failovers killed us in PR2, masking problems from QA until the real bits were 
on the wire -- too late!  Must change for PR3 [nsbeta3+]

Comment 4

[Daniel Veditz [:dveditz] out until Nov 10]

Setting p1 for critical nsbeta3+ bugs

Comment 5

[Phil Peterson]

PDT agrees P1

Comment 6

[Samir Gehani]

This rearchitecture won't fly completely on the Mac for multiple reasons:
1> If SmartDownload doesn't find the redirect it throws up its own error
   message.  We can workaround this in multiple ways: 
   i>  Edit the resources to remove this error dialog (we need to try this).
   ii> Ignore this fact and make the redirect.ini a requirement always for Mac.
2> After parsing the redirect, when we try to call SmartDownload again it just
   hangs.  (Although I do recall verifying that redirects work.)  I've tried 
   unloading and reloading the SmartDownload library before calling it the
   second time around but that doesn't help.  :(

This needs rethinking.

Comment 7

[Samir Gehani]

OK, item 2 listed above is a non-issue: I tested a hacked version of today's 
release build which proved to me that redirects are working.  Found and fixed a 
bug.  However, item 1 still exists -- admittedly not as grave but we'll need to 
make having the redirect.ini around compulsory which means hacking jj's 
BuildCentral scripts to generate a new one for every build.  

Comment 8

[Samir Gehani]

OK, here's the verdict.

1> Redirect is out on the Mac (but the code is left in in case we replace with 
   a new open source download agent eventually).
2> The new architecture is as follows:
   a> If redirect section exists, use the URL from the downloaded ini file 
      matching the selected site identifier.  (QA: no need to test this.)
   b> If site selector section exists, use the 'DomainX' key for the selected 
      site as the URL path to append the zippies and download them.
   c> If no site selector section either, then use the "global" URL, i.e., the 
      URL key in the Gneeral section.

For now, the config.ini template contains the "Default -- sweetlou" site as the 
default.  Bugscape bug 2197 tracks the need to replace this with the external 
site just before we ship.

Comment 9

[Grace Bush]

verified build 2000090604M18