Ensure browser.tabs.autoHide preference exists before asking for boolean value

RESOLVED INVALID

Status

()

Firefox
Tabbed Browser
RESOLVED INVALID
9 years ago
9 years ago

People

(Reporter: WeirdAl, Unassigned)

Tracking

({assertion})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 382601 [details] [diff] [review]
patch (check pref type first)

Suppose the browser.tabs.autoHide preference doesn't exist (because a corporate consumer is updating their Firefox base).

In BrowserStartup(), prepareForStartup() didn't catch the exception.  delayedStartup() never executes, and gSessionHistoryObserver is never added.

The result is this assertion on shutdown:
###!!! ASSERTION: Oops! You're asking for a weak reference to an object that doesn't support that.: 'factoryPtr', file c:/svn/ff_1.0_FF3.5/fx-debug/xpcom/build/nsWeakReference.cpp, line 109
Attachment #382601 - Flags: review?(vladimir)
Attachment #382601 - Flags: review?(vladimir) → review-
Comment on attachment 382601 [details] [diff] [review]
patch (check pref type first)

This pref is in firefox.js, so if you're hitting this you've done something pretty horrible to your Firefox that you should avoid doing!
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.