497565 - main window flashes briefly when opening view-source window

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[philippe (part-time)]

STR
1. load a site.
2. view-source (Cmd-U)

Actual result: the main window flashes briefly while the view-source window opens.

This seems a bit dependent on the organisation of windows: my main window is usually tucked in one top-corner (left or right) while the view-source window opens in the middle of screen. The effect is a bit like the view-source window coming (falling) down out of the top-left corner of the screen (like those cheesy JS animations of yore).

Regressed between
1244657129-20090610110529-cabb8925dcd3-firefox-3.6a1pre.en-US.mac.dmg	10-Jun-2009
and	 
1244650142-20090610090902-1057ca8f2a91-firefox-3.6a1pre.en-US.mac.dmg	10-Jun-2009
(builds fetched from: http://hourly-archive.localgho.st/hourly-archive2/)

Comment 1

[Neil Deakin]

Attachment: fix

The viewsource window is trying to focus itself before being made visible. The fix here is to only call makeKeyAndOrderFront when the window is visible.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This landed as http://hg.mozilla.org/mozilla-central/rev/ec9034099c13