Closed
Bug 497691
Opened 16 years ago
Closed 16 years ago
echo on windows produces extraneous quotes
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
VERIFIED
DUPLICATE
of bug 457394
People
(Reporter: catlee, Unassigned)
Details
Attachments
(1 file)
|
509 bytes,
patch
|
nthomas
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
Some of the steps in our build factories run code like
command=['echo', WithProperties('%(slavename)s')]
On Linux and Mac this outputs
moz2-linux-slave01
On Windows this outputs
"moz2-win32-slave01"
|
Reporter | |
Comment 1•16 years ago
|
||
One place this is messing us up is when echoing out the changeset link on Windows on packaged unittests. When Tinderbox gets ahold of this string, it does some fancy escaping, which breaks the JSON output even worse than it was broken before.
This patch removes the quotes around the href, so that the format is similar to our other changeset links.
Attachment #382831 -
Flags: review?(nthomas)
|
||
Updated•16 years ago
|
Attachment #382831 -
Flags: review?(nthomas) → review+
|
||
Comment 2•16 years ago
|
||
Dup of bug 457394 ?
|
|
Reporter | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> Dup of bug 457394 ?
Yep.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → DUPLICATE
|
||
Comment 4•16 years ago
|
||
Patch nonetheless welcome there if it applies!
V.Duplicate
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Comment 5•16 years ago
|
||
Comment on attachment 382831 [details] [diff] [review]
Remove quotes from changeset link on packaged unittests
changeset: 330:e5eaa669f6a7
Attachment #382831 -
Flags: checked‑in+
|
Assignee | |
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•