Closed
Bug 497784
Opened 17 years ago
Closed 16 years ago
nanojit: fix load opcode checking
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
4.36 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
isOp2() currently includes some but not all load opcodes, but no store opcodes. This patch moves the load opcodes out of isOp2(), adds an isLoad() to oprnd2() and setOprnd2() so loads are covered that way, and also adds a missing case to isLoad().
The problem was found by Graydon's LIR assembler.
Attachment #382898 -
Flags: review?(graydon)
|
||
Updated•17 years ago
|
Attachment #382898 -
Flags: review?(graydon) → review+
|
Assignee | |
Updated•17 years ago
|
Whiteboard: checkin-needed
|
|
||
Comment 1•17 years ago
|
||
Whiteboard: checkin-needed → fixed-in-tracemonkey
|
|
Assignee | |
Comment 2•16 years ago
|
||
Sayre, I suspect you merged this but forgot to mark it here?
|
||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•