49782 - "Edit Card" in Edit menu is tautological

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Blake Ross]

There's no need for the item in the addressbook to say "Edit Card..." and not 
just "Card..."   The item right below it doesn't read "Edit Preferences..."

Comment 1

[scottputterman]

moving to future milestone. You are probably correct. Though it does seem a 
little strange to just have "Card..." in the menu item. It's probably just what 
I'm used to now.

Comment 2

[jglick]

Changing this to "Edit --> Card Properties" is fine with me.

Related to bug 55170.

Comment 3

[Peter "jag" Annema]

Attachment: [patch] "Edit Card" --> "Propert_i_es Ctrl+i"

Comment 4

[Peter "jag" Annema]

Changed "Edit Card" to "Properties", i as accesskey, ctrl+i as accelerator.

Adding patch and review keywords. Whoever notes r=, don't forget to remove
review and add approval.

Comment 5

[scottputterman]

As a favor I would ask that you don't use Ctrl+I. Also, could we make it say
"Card Properties"? If you change that then the rest of the patch looks good to
me and you have r=putterman.

Comment 6

[jglick]

Please change it to "Card Properties" as noted in my previous comment above and 
stated in bug 55170. Thank you. 

Comment 7

[Peter "jag" Annema]

Whoops... Easy fix. Why not ctrl+I? That was requested in bug 55170...

Comment 8

[scottputterman]

ok, I just read that bug.  My comments were meant on the Netscape menu item
(hence the asking for a favor part). But if jglick has knowledge that that menu
item is going to be changed, then go ahead and use Ctrl+I.

Comment 9

[jglick]

As long as this is truck only, using Ctrl+I is ok. Once the netscape builds 
merge back to the truck, we will have a conflict with IM using Ctrl+I.  There is 
already a bugscape bug filed again IM to change the accelerator for new IM from 
Ctrl+I to something else.  We just need to be sure that happens.  Adding Vishy 
to this bug.  I also made a comment about this in the bugscape bug 2263.

Comment 10

[Peter "jag" Annema]

Attachment: [patch] As first one, but "Card Properties..." instead

Comment 11

[scottputterman]

looks good. r=putterman

Comment 12

[Chris Waterson]

a=waterson

Comment 13

[Peter "jag" Annema]

Well, I just checked this in, marking fixed. (Hope you don't mind, putterman).

Comment 14

[scottputterman]

nope. thanks for working on it.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED FIXED on all platforms, today's build 12-26-00