"Edit Card" in Edit menu is tautological

VERIFIED FIXED in Future

Status

SeaMonkey
MailNews: Address Book & Contacts
P3
normal
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: Blake Ross, Assigned: scottputterman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
There's no need for the item in the addressbook to say "Edit Card..." and not 
just "Card..."   The item right below it doesn't read "Edit Preferences..."
(Assignee)

Comment 1

17 years ago
moving to future milestone. You are probably correct. Though it does seem a 
little strange to just have "Card..." in the menu item. It's probably just what 
I'm used to now.
Target Milestone: --- → Future

Comment 2

17 years ago
Changing this to "Edit --> Card Properties" is fine with me.

Related to bug 55170.

Comment 3

17 years ago
Created attachment 16814 [details] [diff] [review]
[patch] "Edit Card" --> "Propert_i_es Ctrl+i"

Comment 4

17 years ago
Changed "Edit Card" to "Properties", i as accesskey, ctrl+i as accelerator.

Adding patch and review keywords. Whoever notes r=, don't forget to remove
review and add approval.
Keywords: patch, review
(Assignee)

Comment 5

17 years ago
As a favor I would ask that you don't use Ctrl+I. Also, could we make it say
"Card Properties"? If you change that then the rest of the patch looks good to
me and you have r=putterman.
Keywords: review

Comment 6

17 years ago
Please change it to "Card Properties" as noted in my previous comment above and 
stated in bug 55170. Thank you. 
Keywords: review

Comment 7

17 years ago
Whoops... Easy fix. Why not ctrl+I? That was requested in bug 55170...
(Assignee)

Comment 8

17 years ago
ok, I just read that bug.  My comments were meant on the Netscape menu item
(hence the asking for a favor part). But if jglick has knowledge that that menu
item is going to be changed, then go ahead and use Ctrl+I.

Comment 9

17 years ago
As long as this is truck only, using Ctrl+I is ok. Once the netscape builds 
merge back to the truck, we will have a conflict with IM using Ctrl+I.  There is 
already a bugscape bug filed again IM to change the accelerator for new IM from 
Ctrl+I to something else.  We just need to be sure that happens.  Adding Vishy 
to this bug.  I also made a comment about this in the bugscape bug 2263.

Comment 10

17 years ago
Created attachment 16820 [details] [diff] [review]
[patch] As first one, but "Card Properties..." instead
(Assignee)

Comment 11

17 years ago
looks good. r=putterman

Comment 12

17 years ago
a=waterson

Comment 13

17 years ago
Well, I just checked this in, marking fixed. (Hope you don't mind, putterman).
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 14

17 years ago
nope. thanks for working on it.
VERIFIED FIXED on all platforms, today's build 12-26-00
Status: RESOLVED → VERIFIED
QA Contact: lchiang → stephend
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.