_PLATFORM_DEFAULT_TOOLKIT of WinCE should be 'cairo-windows' instead of 'windows'

RESOLVED FIXED in mozilla1.9.2a1

Status

defect
RESOLVED FIXED
10 years ago
Last year

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla1.9.2a1
All
Windows CE
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments)

Assignee

Description

10 years ago
Posted patch patch v1Splinter Review
The default value of _PLATFORM_DEFAULT_TOOLKIT of WinCE is invalid.  it should be 'cairo-windows' instead of 'windows'.   On build instruction of WinCE (https://wiki.mozilla.org/Mobile/Build/Windows_Mobile_BuildingIt), it is defined as it.
Attachment #382929 - Flags: review?(ted.mielczarek)
Comment on attachment 382929 [details] [diff] [review]
patch v1

Good call. Those mozconfigs are still depressingly large. We should get more of the defaults in configure set correctly for WinCE builds.
Attachment #382929 - Flags: review?(ted.mielczarek) → review+
Assignee

Comment 2

10 years ago
landed
http://hg.mozilla.org/mozilla-central/rev/c6a2d1342334
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Attachment #427647 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 427647 [details] [diff] [review]
(Bv1) Copy it to comm-central
[Checkin: Comment 4]


http://hg.mozilla.org/comm-central/rev/8b558e5b1cb0
Attachment #427647 - Attachment description: (Bv1) Copy it to comm-central → (Bv1) Copy it to comm-central [Checkin: Comment 4]

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.