Closed Bug 497886 Opened 15 years ago Closed 15 years ago

Document the property cache

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: jorendorff)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

the right patch
5.71 KB, patch
brendan
: review+
Details | Diff | Splinter Review 
It'd be nice if we had docs on how the property cache is supposed to work, what it does, etc.  In particular, it would aid my understanding of bug 497789 comment 3.

waldo, do you think you could pretty please document this if you understand it?  ;)
I fixed the title of the bug ;)
Summary: Document the property cache → Document the property tree and cache and submit it to PLDI'10
Un-lulz-ifying summary and taking.  (Sorry, I have no sense of humor this morning. :)
Assignee: general → jorendorff
Blocks: 480192
Summary: Document the property tree and cache and submit it to PLDI'10 → Document the property cache
Wasn't meant as a joke. I plan on writing a paper on the prop cache for PLDI'10.
Attached patch v1 (obsolete) — — Splinter Review 
This patch goes beyond fixing the bug as described. It turns an "if" in PROPERTY_CACHE_TEST into an assertion. The assertion does not fail on js/tests.

Even in terse js/src-ese, the full propcache story is more than I want to cram into jsinterp.h.  So I put it on devmo and just added a link in jsinterp.h.

  https://developer.mozilla.org/En/SpiderMonkey/Internals/Property_cache

Andreas, get your own bug.  ;-)
Attachment #384982 - Flags: review?(brendan)
Attached patch the right patch — — Splinter Review 
Oops. v1 was the wrong patch.
Attachment #384982 - Attachment is obsolete: true
Attachment #387193 - Flags: review?(brendan)
Attachment #384982 - Flags: review?(brendan)
Review ping. This is burning a hole in my patch queue! :)

Note that the last hunk is obsolete. Both the line being removed and the invariant being asserted are gone.
Tomorrow afternoon -- although didn't I edit the wiki the other week? Who needs review when you have a wiki :-P.

/be
Comment on attachment 387193 [details] [diff] [review]
the right patch

Sorry for the delay, I had thought this was the wiki doc tracking bug!

This may be a bit out of date. Also may conflict with patches in the pipe, but no worries, rs=me -- go strong.

/be
Attachment #387193 - Flags: review?(brendan) → review+
http://hg.mozilla.org/tracemonkey/rev/b416a23a0ec0
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/b416a23a0ec0
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: