497891 - Incorrect plural rules for thread counts in summary page for collapsed threads and multiple selections

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99
Build Identifier: 

Plural rule 9 has three forms, see https://developer.mozilla.org/en/Localization_and_Plurals#Plural_rule_.239_%283_forms%29 but when one test this with polish nightly in summary page header will be displayed:
- with one thread selected there will be no info about threads (intended?)
- with 2,22,23 threads selected the second form will be used (correct)
- with 3,4,24,32,33,34 threads selected third form will be used (incorrect, it should be second)
- with 17,21,26,27,28,31 threads selected the second form will be used (incorrect, it should be third)

Corresponding property:
NConversations = #1 wątek;#1 wątki;#1 wątków

http://mxr.mozilla.org/l10n-central/source/pl/mail/chrome/messenger/multimessageview.properties?raw=1&ctype=

Reproducible: Always

Comment 1

[Mark Banner (:standard8)]

I think I see what is happening here. Patch coming up.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

This should fix it. When you stop looking at the numbers and just look at the code its clear to see that we're using the number of messages to work out the plural form rather than the number of threads which we're actually displaying.

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix v2

Fixes bitrot now the folder display patch has landed.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 383087 [details] [diff] [review]
The fix v2

>+    let messagesTitle = PluralForm.get(numThreads, gSelectionSummaryStrings["NConversations"]).replace('#1', numThreads);

Consider wrapping - and dunno why it's both "s and 's on the same line, prefer " 

>     heading.innerHTML = messagesTitle;
> 
>@@ -317,8 +316,8 @@ MultiMessageSummary.prototype = {
>       }
>       messagesElt.appendChild(msgNode);
>     }
>-    this.computeSize(htmlpane);
>-    this.notifyMaxCountExceeded(numMessages, MAXCOUNT);
>+    this.computeSize(htmlpane); 

Nit: trailing space

r=mkmelin

Comment 5

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/c10b92ea3619