If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

()

Core
Rewriting and Analysis
RESOLVED WONTFIX
8 years ago
5 years ago

People

(Reporter: humph, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Dehydra reports locations that are off (end vs. start of loc), making it hard to provide good source code links in dxr.  As an example, from nsRDFService.cpp.html:

1177 RDFServiceImpl::GetBlobLiteral(const PRUint8 *aBytes, PRInt32 aLength,
1178                                nsIRDFBlob **aResult)
  
The loc for GetBlobLiteral is 1178 vs. 1177.  This isn't the worst example I've seen.  I'll try to find a better one, as I work away.

Comment 1

8 years ago
Created attachment 413718 [details] [diff] [review]
class loc fix

hey please check if this helps. I'm not gonna fix the function loc bug on gcc 4.3 as it seems to be fixed in 4.5 (now that dehydra works with 4.5, you should switch anyway)
Attachment #413718 - Flags: review?(david.humphrey)

Comment 2

8 years ago
forgot to mention, this fixes class classname { locations pointing at '{'

Comment 3

8 years ago
Created attachment 414151 [details] [diff] [review]
fixed version

Good thing you didnt have time to try that. it had a bug that manifested in treehydra failing to build.
Attachment #413718 - Attachment is obsolete: true
Attachment #413718 - Flags: review?(david.humphrey)

Comment 4

8 years ago
Created attachment 415191 [details] [diff] [review]
this should work with 4.3

Updated

8 years ago
Attachment #414151 - Attachment is obsolete: true
Dehydra and treehydra are no longer maintained by Mozilla.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.