Closed
Bug 497972
Opened 15 years ago
Closed 11 years ago
Fix locations in gcc
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: humph, Unassigned)
References
Details
Attachments
(1 file, 2 obsolete files)
|
1.16 KB,
patch
|
Details | Diff | Splinter Review |
Dehydra reports locations that are off (end vs. start of loc), making it hard to provide good source code links in dxr. As an example, from nsRDFService.cpp.html: 1177 RDFServiceImpl::GetBlobLiteral(const PRUint8 *aBytes, PRInt32 aLength, 1178 nsIRDFBlob **aResult) The loc for GetBlobLiteral is 1178 vs. 1177. This isn't the worst example I've seen. I'll try to find a better one, as I work away.
|
||
Comment 1•15 years ago
|
||
hey please check if this helps. I'm not gonna fix the function loc bug on gcc 4.3 as it seems to be fixed in 4.5 (now that dehydra works with 4.5, you should switch anyway)
Attachment #413718 -
Flags: review?(david.humphrey)
|
|
||
Comment 2•15 years ago
|
||
forgot to mention, this fixes class classname { locations pointing at '{'|
|
||
Comment 3•15 years ago
|
||
Good thing you didnt have time to try that. it had a bug that manifested in treehydra failing to build.
Attachment #413718 -
Attachment is obsolete: true
Attachment #413718 -
Flags: review?(david.humphrey)
|
|
||
Comment 4•15 years ago
|
||
|
|
||
Updated•15 years ago
|
Attachment #414151 -
Attachment is obsolete: true
|
||
Comment 5•11 years ago
|
||
Dehydra and treehydra are no longer maintained by Mozilla.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•