498011 - When customizing the contents of the Mail Toolbar, spaces (flexible and not) get drawn with height=0px

Status: RESOLVED INVALID

(Thunderbird :: General, defect)

Description

[Ben Lerner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090612 Lightning/1.0pre Shredder/3.0b3pre

See screenshot.

Reproducible: Always

Steps to Reproduce:
1. Right click on the Mail Toolbar and hit customize.

Actual Results:  
In the *menu* bar, you see the flexible space as a white box filling the height of the menu bar.  In the *toolbar*, the flexible space is shown only by its gray border; the space is of height=0px.  The same holds for non-flexible spaces.

Expected Results:  
Spaces should be drawn correctly, regardless of which bar they're on.

Comment 1

[Ben Lerner]

Attachment: screenshot showing spaces being drawn incorrectly

Comment 2

[Phil Ringnalda (:philor)]

WFM, even after following step 0 (install Lightning) and step 0 (switch to icons-only and small icons) and step 0 (remove all separators) and step 0 (add the Stop button). Could you try to see if there are any other steps, like also installing another extension, or doing something particular in Lightning besides just opening a Calendar tab, or adding some userChrome.css and then forgetting about it?

Comment 3

[Ben Lerner]

That was a bit sloppy of me, I apologize.  I saw the same behavior regardless of which tab I was on (or how many were open, or the sizes of the icons, or the presence of the stop button), so assumed it wasn't the fault of Lightning.  In fact, it isn't.  It also isn't TB's fault -- enabling or disabling the exptoolbar extension triggers the bug, regardless of any of the steps 0 above that I left out.  I'd forgotten I'd still had that installed...

Resolving invalid, my mistake.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Yeah, exptoolbar has some issues with its internal spacers escaping onto the toolbar, presumably due to naming tricking the toolbar customization logic into thinking they are actual toolbar spacers.