Closed Bug 498102 Opened 15 years ago Closed 15 years ago

Adding items to the menu toolbar via customization and autohide toolbars do not play well together

Categories

(Toolkit :: Toolbars and Toolbar Customization, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: wgianopoulos, Unassigned)

References

Details

Adding items to the menubar via toolbar customization makes the autohide menubar feature not work correctly.

Additionally attempting to use the autohide menubar feature after you have customized the menubar ends up altering you menubar customization by adding a flexible space each time you try to toggle the menubar visibility.

These extra flexible spaces do not go away if you go to customize desktop and select "Restore Default Set".

I normally have forecastfox displaying on my menubar.  Left clicking on the radar button is supposed to take you to the accuweather site.  However if you have the menubar hidden and then click on alt to unhide it, clicking on the radar icon merely re-hides the menubar.
(In reply to comment #0)
> I normally have forecastfox displaying on my menubar.  Left clicking on the
> radar button is supposed to take you to the accuweather site.  However if you
> have the menubar hidden and then click on alt to unhide it, clicking on the
> radar icon merely re-hides the menubar.

Auto-hiding is actually expected not to be functional if the menu bar is customized. That is, the menu bar should always be visible. Have you dragged the forecastfox UI there via toolbar customization, or is the menu bar a specific option that forecastfox itself offers?
Item duplication issue: if a separator or flexible space is
added to the menu bar, each time "Menu Bar" is toggled, they are duplicated.

1. Right-click the menu bar and choose Customize...
2. Remove all other customizations from the menu bar
3. Drag and drop "Separator" and "Flexible Space" to the right of the "Help"
menu
4. Right-click and uncheck "Menu Bar"
5. Right-click and enable "Menu Bar"
6. Notice that both the Separator and Flexible Space have been duplicated. 
You may have to choose Customize... to see the Flexible Space duplication.
7. Keep toggling "Menu Bar" and notice that Separator and Flexible Space
duplication keeps occurring.
(In reply to comment #1)
> Auto-hiding is actually expected not to be functional if the menu bar is
> customized. That is, the menu bar should always be visible. Have you dragged
> the forecastfox UI there via toolbar customization, or is the menu bar a
> specific option that forecastfox itself offers?

This is set via a specific option that forecastfox offers.  In reality I am not sure anyone who had forecastfox displaying in this manner would actually be using the menubar autohide feature.  I merely mentioned it as an issue i noted while seeing how the new feature worked.  If were to decide I like the autohide feature and intended to regularly use it, I would probably move forecastfox back to the its default position on the statusbar.
Depends on: 498100
(In reply to comment #4)
> In reality I am not sure anyone who had forecastfox displaying in this manner
> would actually be using the menubar autohide feature.  I merely mentioned it
> as an issue i noted> while seeing how the new feature worked.

It also happens if the "Activity Indicator" is placed in the menu bar, so I'm thinking it might be an issue.
Furthermore, it also happens if the Search Engine Field is placed onto the Menu Bar.

Problem is that once the Search Engine Field is placed in the Menu Bar, it cannot be moved back to the Navigation Bar using the "Customize..." feature.
All of the issues discussed in this bug are corrected by the patch attached to bug 498100 with the exception of the issue with Forecastfox, Forecastbar Enhanced and any other extension that can display on the menubar.  Having these extensions on the menubar should disable the menubar autohide but does not.
Evidently the left clicking failing to open the link is NOT just an issue with the Forecastfox (and similar) extension.  Further testing has reveled that if you unhide the menubar via the ALT key, you can not open links displayed in the content area by left clicking on them.  I decided to spin that off as bug 498176 as it seemed like a separate issue.
Keywords: regression
This is resolved for me with today's nightly.  See if your bugs are also resolved.
I'll call this fixed. Forecastfox could play a little better together with toolbar customization, fwiw.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.