498129 - cairo-qpainter-surface.cpp:1391: error: invalid conversion

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[wbrana]

User-Agent:       Opera/9.80 (X11; Linux x86_64; U; en) Presto/2.2.15 Version/10.00
Build Identifier: mozilla-1.9.1 hg 25971

c++ -o cairo-qpainter-surface.o -c -I../../../../dist/include/system_wrappers -include ../../../../config/gcc_hidden.h -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_COM_OBSOLETE -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DZLIB_INTERNAL -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -DPACKAGE_VERSION="\"moz\"" -DPACKAGE_BUGREPORT="\"http://bugzilla.mozilla.org/\"" -DMOZ_TREE_CAIRO -I. -I. -I. -I../../../../dist/include/png -I../../../../dist/include/zlib -I../../../../dist/include/libpixman -I../../../../dist/include   -I../../../../dist/include/cairo -I/home/mozilla/dist/include/nspr    -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtXml   -I/usr/include/freetype2 -I/home/mozilla/dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -pipe -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -pipe   -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -Wp,-MD,.deps/cairo-qpainter-surface.pp cairo-qpainter-surface.cpp
cairo-qpainter-surface.cpp: In function 'cairo_int_status_t _cairo_qpainter_surface_show_glyphs(void*, cairo_operator_t, cairo_pattern_t*, cairo_glyph_t*, int, cairo_scaled_font_t*, int*)':
cairo-qpainter-surface.cpp:1391: error: invalid conversion from 'int' to 'cairo_text_cluster_flags_t'
cairo-qpainter-surface.cpp: In function 'void _cairo_image_surface_write_to_ppm(cairo_image_surface_t*, const char*)':
cairo-qpainter-surface.cpp:1798: warning: deprecated conversion from string constant to 'char*'
cairo-qpainter-surface.cpp:1800: warning: deprecated conversion from string constant to 'char*'
cairo-qpainter-surface.cpp: At global scope:
cairo-qpainter-surface.cpp:129: warning: 'g_dump_path' defined but not used
cairo-qpainter-surface.cpp:130: warning: 'timer_start_val' defined but not used
cairo-qpainter-surface.cpp:155: warning: 'const char* _opstr(cairo_operator_t)' defined but not used
gmake[5]: *** [cairo-qpainter-surface.o] Error 1
gmake[5]: Leaving directory `/mnt/md3/cache/mozilla/gfx/cairo/cairo/src'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/mnt/md3/cache/mozilla/gfx/cairo'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory `/mnt/md3/cache/mozilla/gfx'
gmake[2]: *** [libs_tier_gecko] Error 2
gmake[2]: Leaving directory `/mnt/md3/cache/mozilla'
gmake[1]: *** [tier_gecko] Error 2
gmake[1]: Leaving directory `/mnt/md3/cache/mozilla'
make: *** [default] Error 2


Reproducible: Always




gcc 4.3.3

Comment 1

[Enno]

Attachment: Proposed fix

gcc 4.2.1 does not like casting an int to an enum.

Comment 2

[Robert Kaiser]

You should request review for this patch. If you're unsure who can review, it usually a good idea to look into the history of that file: http://hg.mozilla.org/mozilla-central/log/tip/gfx/cairo/cairo/src/cairo-qpainter-surface.cpp
People who recently reviewed patches there are usually good candidates for reviewing your patch on the same file as well - and if you need to find their actual Bugzilla ID, look into the bug links in that file history/log and you should find review comments from them there.

Comment 3

[Doug Turner (:dougt)]

I am using gcc version 4.2.1 without any problem.