498244 - Containers on bookmarks toolbar do not open while current page is loading

Status: RESOLVED DUPLICATE of bug 495675

(Firefox :: Bookmarks & History, defect)

Description

[2pawnder]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99

If the current page you're looking at is loading/refreshing, it seems that you cannot open a folder of live bookmarks which is in the bookmark toolbar. When I click it, it doesn't do anything. I don't know if this happens with just the live bookmark, but I made a folder called "Feeds" where all of the live bookmarks are, and that won't open. This only happens when the page itself is loading/refreshing, not when the bookmark is redirecting me to the page. 

Reproducible: Always

Steps to Reproduce:
1. Make a folder with live bookmark(s)
2. Open the folder, then open a page in a live bookmark
3. After you get redirected to the actual web page, and it is loading, try to click on the folder with the live bookmarks again. The web page has to be loading.
Actual Results:  
The animation for the folder/bookmark clicking was displayed, but the contents of the folder was not shown.

Expected Results:  
It should have shown all of the live bookmarks inside the folder I was trying to load. If you are trying to look at your rss feeds in a hurry, this can be a nuisance.

Comment 1

[Drew Willcoxon :adw]

Confirming on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090612 Minefield/3.6a1pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090615 Shiretoko/3.5pre.  Happens with folders too, not just livemarks.  Just as comment 0 described, the button depress "animation" happens but the menu doesn't open, not immediately and not after waiting for the page to load.  No errors in the JS console.  I can see how it would be annoying.

Comment 2

[gLes]

Confirming on Mozilla/5.0 (Windows; U; Windows NT 6.0; hu; rv:1.9.1) Gecko/20090615 Firefox/3.5 (.NET CLR 3.5.30729) (build 3.5rc1)

Also confirming that this bug has existed since 3.5b4, but not until then, and that it is very, very annoying.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

I can't make this happen with a latest branch nightly on OSX, fwiw, but maybe I'm not understanding the STR. I:

 - open a Live Bookmark folder
 - click on an entry
 - as that page loads, open the folder again

works fine.

Comment 4

[Drew Willcoxon :adw]

Hmm, I can reproduce this much less reliably than I could the other day (with each day's current branch nightly).  It doesn't really happen now.  This is how I was doing it:

1. Load any web page.  The longer it takes to load, the better for these STR.
2. While it's loading, try to open any container on the toolbar.

The container gives feedback that it's being depressed but it doesn't open.

Reporters, could you try the most recent nightly?

FWIW, I don't think this should block 3.5, even if I could now reliably reproduce it.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Agreed; if we can figure out what's going on, we can look at taking this in 3.5.1, but doesn't block 3.5 release.

Comment 6

[2pawnder]

I tried it on Minefield--it seems to only work when a page isn't already cached, otherwise it would load too quickly. I think it would be hard to reproduce if the page is loading too quickly.

Comment 7

[gLes]

Erm...I didn't have time to check out the nightly builds (I usually wait for localized builds anyway).

I've recently taken to collecting blogs and stuff like that I read regularly together into a bookmark folders, so if I'm ready for some procrastination I just pop them open with one middle click on the folder. But now I have to wait for the first batch (~10 tabs) to load before I can start picking items from another folder, thus the case being annoying.

I'm not really into Firefox's codebase, but I'm pretty sure this phenomenon was born between beta 3 and beta 4 of version 3.5. I don't know how many diffs that means, probably too much to easily point out the culprit, sorry for my ignorance :)

Comment 8

[Drew Willcoxon :adw]

(In reply to comment #7)
> I've recently taken to collecting blogs and stuff like that I read regularly
> together into a bookmark folders, so if I'm ready for some procrastination I
> just pop them open with one middle click on the folder. But now I have to wait
> for the first batch (~10 tabs) to load before I can start picking items from
> another folder, thus the case being annoying.

Oh yeah, that's a good way to reproduce it, I can now.

Pretty sure this is a dupe of bug 495675, which is due to bug 235244.  If I hold my mouse button down for awhile (~1 second or more) or drag the mouse down slightly and continue to hold, the container opens as expected.  I suspect that since many tabs are loading at once the event pump is pretty busy, exacerbating the behavior of bug 495675.

Reporters, could you confirm?

Comment 9

[gLes]

I just installed 3.5rc2 and it seems the phenomenon has evaporated. The opening of folders while a page is (or a lot of pages are) loading is still a bit jerky, but I think that was accounted as normal behavior even before beta 4.

Comment 10

[Drew Willcoxon :adw]

I'm going to mark this a dupe for now, with the reasoning in comment 8.  Now that bug 495675 has landed on trunk, responsiveness is much better, which is good evidence.

2pawnder, could you try to reproduce on the latest trunk nightly?  Be sure to back up your profile first.  If you can still reproduce, feel free to report back here.

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

Comment 11

[2pawnder]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090625 Minefield/3.6a1pre (.NET CLR 3.5.21022)

Couldn't reproduce it--it's fine now. Thanks!