498277 - nsARIAGridAccessible is used for html:table with role="grid"

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

nsARIAGridAccessible is used for html:table with role="grid". We should use nsHTMLTableAccessible. This was introduced in bug 493552.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 383223 [details] [diff] [review]
patch

This looks correct. However is there a way to catch this with some tests so that we can make sure we always create nsHTMLTableAccessible classes for "real" tables?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 383223 [details] [diff] [review]
patch

r=me with 1 nit:

>+    if (roleMapEntry) {
>+      // Create ARIA grid/treegrid accessibles if node is not of a child or
>+      // valid child of HTML table and is not a HTML table.

Maybe this could be:
"Create ARIA based grid/treegrid accessibles only if the node is not part of an HTML table"

I agree with Marco, let's try to get this under test!

Comment 4

[Marco Zehe (:MarcoZ)]

This needs to land before bug 493723 can reland. With this one fixed, that one no longer causes a regression in JAWS and NVDA.

Comment 5

[alexander :surkov (:asurkov)]

We can't know what class is used for this accessible therefore we can't create direct/correct tests. We could think of indirect tests based on the difference between implementations of nsHTMLTableAccessible and nsARIAGridAccessible but we can't be sure these tests will be valid always. Possibly it's better to leave this untested.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> This needs to land before bug 493723 can reland. With this one fixed, that one
> no longer causes a regression in JAWS and NVDA.

Yes, bug 493723 should get rid the problem from chatzilla, but actually it isn't a real fix of the problem. It may appear for pure ARIA grid tables.

Comment 7

[Marco Zehe (:MarcoZ)]

Pushed on Alexander's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/405d3e86c7f5

Comment 8

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre (.NET CLR 3.5.30729)