Closed Bug 498277 Opened 13 years ago Closed 13 years ago

nsARIAGridAccessible is used for html:table with role="grid"

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

Details

Attachments

(1 file)

nsARIAGridAccessible is used for html:table with role="grid". We should use nsHTMLTableAccessible. This was introduced in bug 493552.
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #383223 - Flags: review?(marco.zehe)
Attachment #383223 - Flags: review?(bolterbugz)
Attachment #383223 - Flags: review?(marco.zehe) → review+
Comment on attachment 383223 [details] [diff] [review]
patch

This looks correct. However is there a way to catch this with some tests so that we can make sure we always create nsHTMLTableAccessible classes for "real" tables?
Attachment #383223 - Flags: review?(bolterbugz) → review+
Comment on attachment 383223 [details] [diff] [review]
patch

r=me with 1 nit:

>+    if (roleMapEntry) {
>+      // Create ARIA grid/treegrid accessibles if node is not of a child or
>+      // valid child of HTML table and is not a HTML table.

Maybe this could be:
"Create ARIA based grid/treegrid accessibles only if the node is not part of an HTML table"

I agree with Marco, let's try to get this under test!
This needs to land before bug 493723 can reland. With this one fixed, that one no longer causes a regression in JAWS and NVDA.
Blocks: 493723
No longer blocks: 493552
We can't know what class is used for this accessible therefore we can't create direct/correct tests. We could think of indirect tests based on the difference between implementations of nsHTMLTableAccessible and nsARIAGridAccessible but we can't be sure these tests will be valid always. Possibly it's better to leave this untested.
(In reply to comment #4)
> This needs to land before bug 493723 can reland. With this one fixed, that one
> no longer causes a regression in JAWS and NVDA.

Yes, bug 493723 should get rid the problem from chatzilla, but actually it isn't a real fix of the problem. It may appear for pure ARIA grid tables.
Pushed on Alexander's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/405d3e86c7f5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090618 Minefield/3.6a1pre (.NET CLR 3.5.30729)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.