498493 - gloda error (labeled as warning): Got impossible folder ID

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[David Ascher (:davida)]

I see this in error console

2009-06-15 11:16:08	gloda.indexer	WARN	Problem during job, trying to recover.  Problem was at undefined:undefined: Got impossible folder ID: 80

No idea why.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: [committed in comment 2] v1 provide more detail on the job we're abandoning

A brief code inspection at the probable origins of such an error yielded nothing.

This patch gets us more debug about what the job is that we're abandoning.  Since my patch for bug 498222 also had a similar idea, note that there will be a conflict between that fix patch and this patch, but this is the one that should win.  (It's more polished and actually has the job describe what it's doing.)

Here's an example (with reduced paths) of what the bug provides (using the failure from bug 498222 as the example):

2009-07-20 03:44:34	gloda.indexer	WARN	Problem during [job:folder delta:0 id:82 items:0 offset:1 goal:3], trying to recover.  Problem was at file:///.../noun_mimetype.js:178: TypeError: aMimeType is undefined. Stack:
  gloda_noun_freetag_toParamAndValue((void 0))@file:///.../noun_mimetype.js:178
  gloda_attr_convertValuesToDBAttributes([object Array])@file:///.../datamodel.js:132
  gloda_ns_grokNounItem([object Object],[object Object],false,false,[object Object],(void 0))@file:///.../gloda.js:1665
  gloda_index_workBatch()@file:///.../indexer.js:1357
  gloda_index_callbackDriver()@file:///.../indexer.js:1224
  gloda_index_wrapCallbackDriver([object XPCWrappedNative_NoHelper])@file:///.../indexer.js:1161

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

pushed improved error logging:
http://build.mozillamessaging.com/mercurial/comm-central/rev/f33c2acfd4cb

Comment 3

[David Ascher (:davida)]

More data.

2009-07-28 14:19:58	gloda.indexer	DEBUG	<<<  _indexMessage
2009-07-28 14:19:58	gloda.indexer	DEBUG	>>>  _indexMessage
2009-07-28 14:19:58	gloda.indexer	DEBUG	*** Indexing message: 302062 : [Bug 395701] mailnews should use nsStringGlue and other Glue code
2009-07-28 14:19:58	gloda.datastore	DEBUG	QUERY FROM QUERY: SELECT * FROM conversations WHERE (id IN (235)) ARGS: 
2009-07-28 14:19:58	gloda.ds.mbm	DEBUG	getting results...
2009-07-28 14:19:58	gloda.ds.mbm	DEBUG	query completed, notifying... Message:660,Message:661,Message:1014
2009-07-28 14:19:58	gloda.indexer	DEBUG	ancestors raw: Message:660,Message:661,Message:1014
2009-07-28 14:19:58	gloda.indexer	DEBUG	ref len: 2 anc len: 2
2009-07-28 14:19:58	gloda.indexer	DEBUG	references: 0 = [e-mail]/,1 = [e-mail]
2009-07-28 14:19:58	gloda.indexer	DEBUG	ancestors: 0 = Message:660,1 = Message:661,Message:1014
2009-07-28 14:19:58	gloda.indexer	DEBUG	2 candidate messages
2009-07-28 14:19:58	gloda.indexer	DEBUG	candidate folderID: 35 messageKey: 258
2009-07-28 14:19:58	gloda.indexer	DEBUG	candidate folderID: 16 messageKey: 302062
2009-07-28 14:19:58	gloda.indexer	WARN	Problem during job, trying to recover.  Problem was at undefined:undefined: Got impossible folder ID: 16


The cause was likely an IMAP rename, which caused all kinds of unhappiness.

Marking blocking, as it seems to stop further indexing of messages in the affected folder, which is bad.

Comment 4

[Simon Paquet [:sipaq]]

Marking this as "[no l10n impact]" for now. But if we decide to move the error message into localizable space that would change.

Comment 5

[David Ascher (:davida)]

Andrew, what should the milestone for this bug be?

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

With the "more data" from comment #3 I understand the problem now.  The problem is that the ghost message's state is illegal but possible.  This will likely be resolved by proper deletion logic, but a minor change may be required here.  Moving to beta 4 to be with its gloda key friends.

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Attachment: v1 workaround having a bad folderid. this should probably improve things enough.

Comment 8

[David :Bienvenu]

Comment on attachment 400602 [details] [diff] [review]
v1 workaround having a bad folderid.  this should probably improve things enough.

looks reasonable.

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Fixed in gloda correctness patch tracked on bug 465618.
trunk commit: http://hg.mozilla.org/comm-central/rev/413b2018349c

The fix marking is actually for the commit of the workaround patch which landed in commit: http://hg.mozilla.org/comm-central/rev/cbae38f29de7