498556 - make tests resilient to latest mozmill changes

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[David Ascher (:davida)]

Attachment: trivial patch

mozmill trunk predefines Cc, Cu, and Ci variables before runing the tests.  Our current tests define them as constants, which causes the script loader in frame.js/loadFile() to fail (miserably).

(note: this was introduced in rev 482 of mozmill, see http://code.google.com/p/mozmill/source/diff?spec=svn482&r=480&format=side&path=/trunk/mozmill/extension/resource/modules/frame.js&old_path=/trunk/mozmill/extension/resource/modules/frame.js&old=474)

The attached patch allows the test suite to run "better" (it's still not 100% runnable for me, due to other issues).

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 383402 [details] [diff] [review]
trivial patch

Stealing the review since I allegedly should have review authority for this now.

This makes the unit tests work for me with latest mozmill trunk, where they are broken without it.  Hooray+

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

pushed: http://hg.mozilla.org/comm-central/rev/dd9f6dee0ce3