498586 - Wrong behavior of crypt function in Firefox 3.5 Preview (with JIT for content enabled)

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect, P1)

Description

[Paweł Kondzior]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99

Crypt is class for client side password hashing with salt, it's broke on firefox 3.5 Preview with JIT for content enabled

Reproducible: Always

Steps to Reproduce:
1. Open attached test case in Firefox 3.5 Preview
2. Result is and Should be values will be different



I use this crypt function for hashing password from client side on my site, with Firefox 3.5 Preview users cannot log in to my page.

Comment 1

[Paweł Kondzior]

Attachment: Testcase

Comment 2

[Andreas Gal :gal]

Investigating. If I can confirm this, we probably have to block on it. Asking for b? in the meantime. Hold off on b+ until I looked at it.

Comment 3

[Jeff Walden [:Waldo]]

Andreas, I apologize for ever having written code (well, ported it, see the comment from the original source linked below) so ugly as that and for making you grovel through it:

http://whereswalden.com/tech/internet/javacrypt/

Comment 4

[Jeff Walden [:Waldo]]

The (my!) testcase works for me in a 20090615 nightly; with any luck we fixed this between 20090605 and now -- not implausible given some of the bugs fixed in that time.

Comment 5

[Andreas Gal :gal]

This works in TM tip shell. We need a regression window.

Comment 6

[Andreas Gal :gal]

Confirmed to work in 1.9.1 tip shell. Closing as WFM based on Waldo's and my own testing. Pawel, can you confirm with rc1?

(we should still bisect this)

Comment 7

[Paweł Kondzior]

With Firefox 3.5 RC1 crypt() works ok. testcase result is correct, and i can loggin on my page.