autohide="true" should be a no-op for menu toolbars on Linux

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Toolkit
Toolbars and Toolbar Customization
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla1.9.2a1
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

796 bytes, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 383468 [details] [diff] [review]
patch

The way auto-hiding is non-standard on Linux and only works is funky: Unlike on Windows, the menu bar doesn't get activated when pressing Alt, but when pressing Alt+[some shortcut key]. So there's a discoverability problem. It seems like no application should really do that on Linux. Instead of letting the apps set autohide="true" in a platform specific section, we should enable it only on platforms where it makes sense.
Attachment #383468 - Flags: review?(neil)
(Assignee)

Comment 1

9 years ago
(In reply to comment #0)
> The way auto-hiding is non-standard on Linux and only works is funky:

What I was trying to say: Auto-hiding is non-standard on Linux, and the way it works is funky.

Comment 2

9 years ago
Comment on attachment 383468 [details] [diff] [review]
patch

I guess if an app really wanted autohide (e.g. for a fullscreen menubar) it could just specify the binding in its own CSS?
Attachment #383468 - Flags: review?(neil) → review+
(Assignee)

Comment 3

9 years ago
(In reply to comment #2)
> I guess if an app really wanted autohide (e.g. for a fullscreen menubar) it
> could just specify the binding in its own CSS?

Not quite. The binding isn't restricted, but the ifdef'd CSS code in xul.css is needed to make it work.
(Assignee)

Comment 4

9 years ago
That is, not only -moz-binding is needed, but also overflow:hidden, height:0, etc. The stuff with [inactive="true"] in the selector could be moved outside of the ifdef, but overflow:hidden would still be inside of it.

Comment 5

9 years ago
OK, so it could just copy the entire CSS block then, which is probably what I was thinking of anyway.
(Assignee)

Comment 6

9 years ago
Yep, that would work.
(Assignee)

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/92b6868ef3f4
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.