498678 - Periods (.) should be acceptable in article titles

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[[:Cww]]

Not being able to have version numbers or website names in article titles is very annoying.  (eg both of the following would be broken: Firefox does not load emails on Yahoo.com or Cannot update from early versions of Firefox 3.0 to Firefox 3.5)

This bug is to investigate WHY we can't have . and if we can make that allowable.

See also bug 474368 and bug 465029

Comment 1

[Paul Craciunoiu [:paulc]]

As per bug 465029 comment 6, this should be fixed once we upgrade.

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This allows dots in articles, but articles ending with ".redirected" won't work because of this rule:
RewriteRule ^([\-a-zA-Z]+)/kb/([^\?]+)\.redirected$    tiki-index.php?page=$2&locale=$1&redirected=y     [QSA,L]

I think that's acceptable.

Comment 3

[Laura Thomson :laura]

Comment on attachment 388818 [details] [diff] [review]
patch, v1

This will work, but we need to test for side effects (QA!!!) :)

Comment 4

[Paul Craciunoiu [:paulc]]

r48068 / r48069
Will need to run webroot/htaccess.sh to see this. I'll file an IT bug (wiating to see if there are other htaccess patches first)

Comment 5

[raymond [:retornam] (inactive)]

verified fixed on https://support-stage.mozilla.org/tiki-view_forum_thread.php?comments_parentId=374593&forumId=1

Comment 6

[Paul Craciunoiu [:paulc]]

This actually refers to KB articles.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Per IRC, reopening because when kicking off a URL such as https://support-stage.mozilla.org/tiki-editpage.php?page=this.article.title.has.a.lot.of.periods&quickedit=Edit, I see just an empty SUMO page.

Comment 8

[Paul Craciunoiu [:paulc]]

While testing, I found out allowing periods "breaks" the friendly URLs for tiki links. I will try to update this bug for that + the exclude "." from the warning in bug 465029.

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: patch, v2

This allows periods for the list of bad characters in bug 465029. Figured it makes more sense to file this here.

Comment 10

[Paul Craciunoiu [:paulc]]

Attachment: SQL update

This is the SQL update that will allow articles with periods to be rewritten to friendly URLs. To test this, make sure to clear the cache (in cachelib.php).

Comment 11

[Paul Craciunoiu [:paulc]]

r48732 / r48733

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Comment 7's URL, https://support-stage.mozilla.org/tiki-editpage.php?page=this.article.title.has.a.lot.of.periods&quickedit=Edit, now works for me; is that enough to verify this, or do I have to wait for SQL to be run, to test the "friendly URLs" mentioned in comment 10?

How do I test that part, BTW?

Comment 13

[[:Cww]]

go to https://support-stage.mozilla.org/kb/this.article.title.has.a.lot.of.periods?bl=n

(currently dead but should give article when sql is run.)

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

And when will the SQL be run?  Is there a bug filed, Paul?

Comment 15

[Paul Craciunoiu [:paulc]]

(In reply to comment #13)
> (currently dead but should give article when sql is run.)
Actually, it'll be dead until htaccess.sh is run.
(In reply to comment #14)
> And when will the SQL be run?  Is there a bug filed, Paul?
I thought to wait for other SQL bugs, but why not bug IT with this and file another one when we have others? :)

Comment 16

[Paul Craciunoiu [:paulc]]

Filed bug 508925 for testing on stage.

Comment 17

[Paul Craciunoiu [:paulc]]

Yay, article in comment 13 works now! Check it out Stephen :)

However, the log wasn't enabled for me on that page. Noted in bug 500239.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/kb/this.article.title.has.a.lot.of.periods?bl=n when logged in beforehand; bug 500239 is separate.

Comment 19

[Paul Craciunoiu [:paulc]]

This created a regression -- see bug 513823

Backed out in 51084 / 51088.

Comment 20

[Paul Craciunoiu [:paulc]]

Filed bug 515302. We should reapply this patch as originally posted once that bug is fixed.

Comment 21

[Paul Craciunoiu [:paulc]]

re-committed first patch in r51156 / r51157

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support-stage.mozilla.org/en-US/kb/this.article.title.has.a.lot.of.periods?bl=n -- tested:

* creating
* renaming
* translating

Also, regression-tested the disallowed characters functionality.

Comment 23

[Louis-Philippe Huberdeau]

I made sure the badchar list matches the latest version on SUMO.

However, the rewrite rules are likely to be sumo_only, which is not an issue since they are entirely custom, for now. The ones in the standard distribution seem more permissive.