498840 - Duplicated accesskey in the Toolbar search

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of the duplicated accesskey

In the Toolbar search, "Copy" and "Clear Search History" share the same accesskey "C" (cmd_showSuggestions_accesskey in browser/locales/en-US/chrome/browser/search.properties).

This issue affects also the mozilla1.9.1 branch

Comment 1

[Francesco Lodolo [:flod]]

Sorry, the name of the key is obviously cmd_clearHistory_accesskey

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Patch to change accesskey for "Clear Search History"

This was originally reported on Firefox 3.5, but it's affecting also 3.6 and latest trunk (Gecko/20100716 Minefield/4.0b2pre).

"H" seems to be a good solution, I'll try to add a patch but I'm not sure if I'm doing it right (never done that for something outside my locale). BTW, the same patch should apply also to mozilla1.9.2 branch, since the last change to that file was done in bug 444735 a couple of years ago and it didn't even touch that accesskey.

Comment 3

[Francesco Lodolo [:flod]]

Gavin, thanks for the review. Do you think that is worth adding this patch also to the mozilla1.9.2 branch (and, I suppose, setting approval1.9.2.8 -> ?)

Comment 4

[Dão Gottwald [:dao]]

You need to request approval2.0 on this patch before it can land.

Comment 5

[Axel Hecht [:Pike]]

Adding back checkin-needed as this got blocking betaN, good to land, per #planning.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I suppose it can land on 1.9.2 as well, though I don't think it's particularly important that it does :)

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/9845d3281525

Comment 8

[Francesco Lodolo [:flod]]

Verified with Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100722 Minefield/4.0b3pre