Duplicated accesskey in the Toolbar search

VERIFIED FIXED in Firefox 4.0b3

Status

()

VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: flod, Assigned: flod)

Tracking

3.5 Branch
Firefox 4.0b3
x86
All
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
In the Toolbar search, "Copy" and "Clear Search History" share the same accesskey "C" (cmd_showSuggestions_accesskey in browser/locales/en-US/chrome/browser/search.properties).

This issue affects also the mozilla1.9.1 branch
(Assignee)

Comment 1

10 years ago
Sorry, the name of the key is obviously cmd_clearHistory_accesskey
(Assignee)

Comment 2

9 years ago
This was originally reported on Firefox 3.5, but it's affecting also 3.6 and latest trunk (Gecko/20100716 Minefield/4.0b2pre).

"H" seems to be a good solution, I'll try to add a patch but I'm not sure if I'm doing it right (never done that for something outside my locale). BTW, the same patch should apply also to mozilla1.9.2 branch, since the last change to that file was done in bug 444735 a couple of years ago and it didn't even touch that accesskey.
(Assignee)

Updated

9 years ago
Attachment #458045 - Flags: review?(gavin.sharp)
Attachment #458045 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

9 years ago
Gavin, thanks for the review. Do you think that is worth adding this patch also to the mozilla1.9.2 branch (and, I suppose, setting approval1.9.2.8 -> ?)
Assignee: nobody → francesco.lodolo
You need to request approval2.0 on this patch before it can land.
Keywords: checkin-needed
(Assignee)

Updated

9 years ago
Attachment #458045 - Flags: approval2.0?

Updated

9 years ago
blocking2.0: --- → betaN+
Adding back checkin-needed as this got blocking betaN, good to land, per #planning.
Keywords: checkin-needed
I suppose it can land on 1.9.2 as well, though I don't think it's particularly important that it does :)
http://hg.mozilla.org/mozilla-central/rev/9845d3281525
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
(Assignee)

Comment 8

9 years ago
Verified with Mozilla/5.0 (Windows; Windows NT 6.1; WOW64; rv:2.0b3pre) Gecko/20100722 Minefield/4.0b3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.