498852 - allow menu bar auto hiding regardless of toolbar customization

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

updated to trunk... hasCustomInteractiveItems has been added in bug 499298

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I don't understand the reasoning here. Where does "can't be hidden" come from? Hiding a menubar with customized items on it seems to work fine, so I don't understand why we'd prevent it.

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> Hiding a menubar with customized items on it seems to work fine

Seems like this broke at some point. If you open a new window, the menu bar will still be shown.

> I don't understand why we'd prevent it.

Because the items aren't usable this way.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> If you open a new window, the menu bar will still be shown.

Can't we fix that instead?

> > I don't understand why we'd prevent it.
> 
> Because the items aren't usable this way.

We don't disable the hiding of other toolbars if they are customized, for good reason (e.g. hiding a toolbar can be temporary). I don't see why the menu bar should be an exception.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> (In reply to comment #3)
> > If you open a new window, the menu bar will still be shown.
> 
> Can't we fix that instead?

Sure, we could, except that it's currently intentional.

> > > I don't understand why we'd prevent it.
> > 
> > Because the items aren't usable this way.
> 
> We don't disable the hiding of other toolbars if they are customized, for good
> reason (e.g. hiding a toolbar can be temporary). I don't see why the menu bar
> should be an exception.

Users will see the items on the menu bar when pressing Alt and expect them to work.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> Sure, we could, except that it's currently intentional.

What's the reasoning behind that?

> Users will see the items on the menu bar when pressing Alt and expect them to
> work.

Why don't they work then?

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #6)
> (In reply to comment #5)
> > Sure, we could, except that it's currently intentional.
> 
> What's the reasoning behind that?

That's the same question as in comment 2, isn't it? The idea is that auto-hiding should be prevented if other items are on the toolbar.

> > Users will see the items on the menu bar when pressing Alt and expect them to
> > work.
> 
> Why don't they work then?

Because attempts to use them trigger the DOMMenuBarInactive event, which causes the menu bar to hide.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Heh, it seems like we're going around in circles here. My expectation is that menubar (auto-)hiding works, regardless of customization state. I would also expect custom menu items on Alt-shown autohidden menubars to work. Are you saying that we can't make them work? Even if that's true, I'm not sure that it means we should disallow auto-hiding. It could still be that someone wants to just hide the menu bar temporarily, in which case they don't care about being able to use it with Alt.

Comment 9

[Dão Gottwald [:dao]]

(In reply to comment #8)
> Heh, it seems like we're going around in circles here. My expectation is that
> menubar (auto-)hiding works, regardless of customization state. I would also
> expect custom menu items on Alt-shown autohidden menubars to work. Are you
> saying that we can't make them work?

Custom menuitems would work, as they wouldn't be directly on the toolbar but inside the menubar element. But maybe I misunderstand your question...

Comment 10

[Dão Gottwald [:dao]]

Attachment: allow auto hiding regardless of toolbar customization

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #9)
> > Are you saying that we can't make them work?
> 
> Custom menuitems would work, as they wouldn't be directly on the toolbar but
> inside the menubar element. But maybe I misunderstand your question...

I meant custom toolbaritems (e.g. a button dragged onto the menubar). Is there something we can do to make them work on auto-hidden menubars (i.e. work around the problem described in comment 7)?

Comment 12

[Dão Gottwald [:dao]]

There's already code in toolbar.xml for making right-clicks on the toolbar work. I suppose this could be extended for other actions, but it won't be pretty.

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/8d563161748b

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization

this should land on 1.9.2 to fix bug 526460

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Dao, I would like to at a Litmus test for that. It would be great to know which possible paths we have to take to test the menu bar auto-hiding after a customization.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #15)
> It would be great to know which
> possible paths we have to take to test the menu bar auto-hiding after a
> customization.

I'm not sure what you mean. If you're asking about ways to enable auto-hiding, then the answer is that there are only two: Unchecking "Menu Bar" in the toolbars' context menu or unchecking it in View -> Toolbars. They both do the same and don't need to be tested separately.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No, I'm talking about which customizations have to be made to see the behavior of that bug. If you have a fresh profile created with 3.6 is it enough to move only one toolbar button to the menu bar? Was that responsible for the brokenness of the auto-hiding feature?

Comment 18

[Dão Gottwald [:dao]]

Any item except for spacers and separators would disable auto-hiding (in new windows or after a restart anyway).

Comment 19

[Edoardo Tirtarahardja]

Any plan to include this in FireFox 3.6.1?

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization

Moving flag to 1.9.2.3

Comment 21

[Daniel Veditz [:dveditz]]

Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization

Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.