Closed Bug 498852 Opened 12 years ago Closed 11 years ago

allow menu bar auto hiding regardless of toolbar customization

Categories

(Toolkit :: XUL Widgets, defect)

All
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: ue)

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #383670 - Flags: review?(gavin.sharp)
Attached patch patch (obsolete) — Splinter Review
updated to trunk... hasCustomInteractiveItems has been added in bug 499298
Attachment #383670 - Attachment is obsolete: true
Attachment #385367 - Flags: review?(gavin.sharp)
Attachment #383670 - Flags: review?(gavin.sharp)
I don't understand the reasoning here. Where does "can't be hidden" come from? Hiding a menubar with customized items on it seems to work fine, so I don't understand why we'd prevent it.
(In reply to comment #2)
> Hiding a menubar with customized items on it seems to work fine

Seems like this broke at some point. If you open a new window, the menu bar will still be shown.

> I don't understand why we'd prevent it.

Because the items aren't usable this way.
(In reply to comment #3)
> If you open a new window, the menu bar will still be shown.

Can't we fix that instead?

> > I don't understand why we'd prevent it.
> 
> Because the items aren't usable this way.

We don't disable the hiding of other toolbars if they are customized, for good reason (e.g. hiding a toolbar can be temporary). I don't see why the menu bar should be an exception.
(In reply to comment #4)
> (In reply to comment #3)
> > If you open a new window, the menu bar will still be shown.
> 
> Can't we fix that instead?

Sure, we could, except that it's currently intentional.

> > > I don't understand why we'd prevent it.
> > 
> > Because the items aren't usable this way.
> 
> We don't disable the hiding of other toolbars if they are customized, for good
> reason (e.g. hiding a toolbar can be temporary). I don't see why the menu bar
> should be an exception.

Users will see the items on the menu bar when pressing Alt and expect them to work.
(In reply to comment #5)
> Sure, we could, except that it's currently intentional.

What's the reasoning behind that?

> Users will see the items on the menu bar when pressing Alt and expect them to
> work.

Why don't they work then?
(In reply to comment #6)
> (In reply to comment #5)
> > Sure, we could, except that it's currently intentional.
> 
> What's the reasoning behind that?

That's the same question as in comment 2, isn't it? The idea is that auto-hiding should be prevented if other items are on the toolbar.

> > Users will see the items on the menu bar when pressing Alt and expect them to
> > work.
> 
> Why don't they work then?

Because attempts to use them trigger the DOMMenuBarInactive event, which causes the menu bar to hide.
Heh, it seems like we're going around in circles here. My expectation is that menubar (auto-)hiding works, regardless of customization state. I would also expect custom menu items on Alt-shown autohidden menubars to work. Are you saying that we can't make them work? Even if that's true, I'm not sure that it means we should disallow auto-hiding. It could still be that someone wants to just hide the menu bar temporarily, in which case they don't care about being able to use it with Alt.
(In reply to comment #8)
> Heh, it seems like we're going around in circles here. My expectation is that
> menubar (auto-)hiding works, regardless of customization state. I would also
> expect custom menu items on Alt-shown autohidden menubars to work. Are you
> saying that we can't make them work?

Custom menuitems would work, as they wouldn't be directly on the toolbar but inside the menubar element. But maybe I misunderstand your question...
Attachment #423308 - Flags: review?(gavin.sharp) → review+
(In reply to comment #9)
> > Are you saying that we can't make them work?
> 
> Custom menuitems would work, as they wouldn't be directly on the toolbar but
> inside the menubar element. But maybe I misunderstand your question...

I meant custom toolbaritems (e.g. a button dragged onto the menubar). Is there something we can do to make them work on auto-hidden menubars (i.e. work around the problem described in comment 7)?
Attachment #385367 - Flags: review?(gavin.sharp)
There's already code in toolbar.xml for making right-clicks on the toolbar work. I suppose this could be extended for other actions, but it won't be pretty.
Blocks: 538580, 526460
Component: Toolbars → XUL Widgets
Product: Firefox → Toolkit
QA Contact: toolbars → xul.widgets
Summary: View > Toolbars > Menu Bar should be disabled if the menu bar can't be hidden due to toolbar customization → allow menu bar auto hiding regardless of toolbar customization
Attachment #385367 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/8d563161748b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization

this should land on 1.9.2 to fix bug 526460
Attachment #423308 - Flags: approval1.9.2.1?
Dao, I would like to at a Litmus test for that. It would be great to know which possible paths we have to take to test the menu bar auto-hiding after a customization.
Flags: in-litmus?
(In reply to comment #15)
> It would be great to know which
> possible paths we have to take to test the menu bar auto-hiding after a
> customization.

I'm not sure what you mean. If you're asking about ways to enable auto-hiding, then the answer is that there are only two: Unchecking "Menu Bar" in the toolbars' context menu or unchecking it in View -> Toolbars. They both do the same and don't need to be tested separately.
No, I'm talking about which customizations have to be made to see the behavior of that bug. If you have a fresh profile created with 3.6 is it enough to move only one toolbar button to the menu bar? Was that responsible for the brokenness of the auto-hiding feature?
Any item except for spacers and separators would disable auto-hiding (in new windows or after a restart anyway).
Any plan to include this in FireFox 3.6.1?
Attachment #423308 - Flags: approval1.9.2.2? → approval1.9.2.3?
Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization

Moving flag to 1.9.2.3
Comment on attachment 423308 [details] [diff] [review]
allow auto hiding regardless of toolbar customization

Clearing old approval requests now that 1.9.2.4 has shipped. If you believe this patch is still necessary on the 1.9.2 branch please re-request approval along with a risk/benefit analysis explaining why we need it.
Attachment #423308 - Flags: approval1.9.2.4?
No longer blocks: 538580
Duplicate of this bug: 538580
Depends on: 688933
You need to log in before you can comment on or make changes to this bug.