498862 - build error in script_alloc_ops on CodeWarrior for Symbian emulator

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Makoto Kato [:m_kato]]

http://mxr.mozilla.org/mozilla-central/source/js/src/jshash.h#68

68 typedef struct JSHashAllocOps {
69     void *              (*allocTable)(void *pool, size_t size);
70     void                (*freeTable)(void *pool, void *item, size_t size);
71     JSHashEntry *       (*allocEntry)(void *pool, const void *key);
72     void                (*freeEntry)(void *pool, JSHashEntry *he, uintN flag);
73 } JSHashAllocOps;

http://mxr.mozilla.org/mozilla-central/source/js/jsd/jsd_scpt.c

253 static JSHashAllocOps script_alloc_ops = {
254     jsd_alloc_script_table, jsd_free_script_table,
255     jsd_alloc_script_entry, jsd_free_script_entry
256 };

But jsd_free_script_table function is defined as...

231 static void
232 jsd_free_script_table(void *priv, void *item)
233 {
234     free(item);
235 }

So, CodeWarrior for Symbian causes build error.  We need add 3rd parameter of jsd_free_script_table.

Of cource, even if using gcc, it outputs warning message "initialization from incompatible pointer type".

Comment 1

[Makoto Kato [:m_kato]]

Attachment: patch v1

Comment 2

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/mozilla-central/rev/4076856822e4