Closed Bug 498862 Opened 12 years ago Closed 12 years ago

build error in script_alloc_ops on CodeWarrior for Symbian emulator

Categories

(Core :: JavaScript Engine, defect)

All
Symbian
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: m_kato, Assigned: m_kato)

References

()

Details

Attachments

(1 file)

http://mxr.mozilla.org/mozilla-central/source/js/src/jshash.h#68

68 typedef struct JSHashAllocOps {
69     void *              (*allocTable)(void *pool, size_t size);
70     void                (*freeTable)(void *pool, void *item, size_t size);
71     JSHashEntry *       (*allocEntry)(void *pool, const void *key);
72     void                (*freeEntry)(void *pool, JSHashEntry *he, uintN flag);
73 } JSHashAllocOps;

http://mxr.mozilla.org/mozilla-central/source/js/jsd/jsd_scpt.c

253 static JSHashAllocOps script_alloc_ops = {
254     jsd_alloc_script_table, jsd_free_script_table,
255     jsd_alloc_script_entry, jsd_free_script_entry
256 };

But jsd_free_script_table function is defined as...

231 static void
232 jsd_free_script_table(void *priv, void *item)
233 {
234     free(item);
235 }

So, CodeWarrior for Symbian causes build error.  We need add 3rd parameter of jsd_free_script_table.

Of cource, even if using gcc, it outputs warning message "initialization from incompatible pointer type".
Attached patch patch v1Splinter Review
Attachment #383680 - Flags: review?
Attachment #383680 - Flags: review? → review?(timeless)
Attachment #383680 - Flags: review?(timeless) → review+
landed
http://hg.mozilla.org/mozilla-central/rev/4076856822e4
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in before you can comment on or make changes to this bug.