498942 - "detailed review" should be capitalized

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Dave Garrett]

nit-pick: "detailed review" on the add-on pages should be capitalized to "Detailed Review"

In the newer layout on preview the "Review Guidelines" link is now always shown right above it. Looks odd to have title case for one link and then lower case for the other. (though, the strings have the same issue on production)

Comment 1

[RJ Walsh [:rjwalsh]]

Attachment: Smallest patch ever!

Comment 2

[Dave Garrett]

Isn't that just a string ID? I think you need to change this in 
app/locale/en_US/LC_MESSAGES/messages.po

Comment 3

[Dave Garrett]

If you want to capitalize the ID too, you'd also need to do so in all the other locale files.

Comment 4

[RJ Walsh [:rjwalsh]]

Hey Dave, thanks for the feedback.  I guess since most of the strings I've modified thus far have just been fallback based, I didn't consider this as an issue.

We can ignore this patch for now, I'll post a new one tomorrow.

Comment 5

[Wil Clouser [:clouserw]]

Yeah, that's a new issue with L10n (that everyone else in the world deals with).  As I understand it, the guidelines are:

- if it's a really minor tweak like capitalization the msgstr can differ from the msgid in the .po.

- Since we're in an L10n freeze and massively changing the files right now, we can go ahead and change the msgid.  However, we can't commit this right now due to the freeze and waiting on gandalf's final script.  I have a script that will s/x/y/g recursively if you want to assign this to me.

Comment 6

[Wil Clouser [:clouserw]]

r49454

Comment 7

[Dave Garrett]

I was suggesting "Detailed Review" not "Detailed review" to match the "Review Guidelines" directly next to it.

Comment 8

[Wil Clouser [:clouserw]]

fine then, r49472

Comment 9

[Dave Garrett]

Thanks. Looks good.

Went from "smallest patch ever" to largest patch possible for such a trivial change". :)