Closed
Bug 498959
Opened 16 years ago
Closed 16 years ago
TraitsBindings::findInterfaceAddr should ignore lower 3 bits of interface
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
579 bytes,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
pre-TraitsBindings, findInterfaceAddr ignored the lower 3 bits of the interface since they are always zero, giving a better hash. this got lost, and should be re-added.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #383775 -
Flags: review?(edwsmith)
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 383775 [details] [diff] [review]
Patch
note that the way this is coded, if a 64bit os puts our memory above the 4gb range, then casting pointer to int gives all zeros. maybe want to xor the two halves together if we're building a 32bit hash.
Attachment #383775 -
Flags: review?(edwsmith) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2)
> (From update of attachment 383775 [details] [diff] [review])
> note that the way this is coded, if a 64bit os puts our memory above the 4gb
> range, then casting pointer to int gives all zeros. maybe want to xor the two
> halves together if we're building a 32bit hash.
probably -- a few other places with similar symptoms. smells like a new bug for that is in order.
|
|
Assignee | |
Comment 4•16 years ago
|
||
pushed to redux as changeset: 2025:447464354e3d
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•16 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•