Closed
Bug 498974
Opened 15 years ago
Closed 15 years ago
WidgetStack.panBy needs to round parameters
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
fennec1.0b2
People
(Reporter: bcombee, Assigned: bcombee)
Details
Attachments
(1 file)
|
427 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
In order to keep panning sane, any dx/dy values passed to panBy need to be rounded to the closest integer number. The kinetic code in InputHandler.js currently passes some float values, which causes errors sometimes.
Attachment #383771 -
Flags: review?(gavin.sharp)
|
||
Updated•15 years ago
|
Attachment #383771 -
Flags: review?(gavin.sharp) → review+
|
|
||
Comment 1•15 years ago
|
||
https://hg.mozilla.org/mobile-browser/rev/5139b1560425
Assignee: nobody → combee
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → B2
|
||
Comment 2•15 years ago
|
||
What sort of errors can occur from not rounding? Possibly panning not stopping or adjusting after a stop (like in bug 485833 ) ?
You need to log in
before you can comment on or make changes to this bug.
Description
•