Closed
Bug 499121
Opened 17 years ago
Closed 17 years ago
Cache user objects for Bug::GetComments
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.4
People
(Reporter: bbaetz, Assigned: bbaetz)
Details
(Keywords: perf)
Attachments
(1 file)
|
712 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
In practice the same people tend to comment more than once on a bug. We should cache reuse the user object (Ideally these would all be singletons, but.....)
For a bug with 57 comments, all by the same user, this moves from 1.07s=>970ms
For 3 comments by two users, 274ms->263ms
Would like this for 3.4 too.
Attachment #383907 -
Flags: review?(mkanat)
|
Assignee | |
Updated•17 years ago
|
Assignee: create-and-change → bbaetz
Version: 3.5 → 3.3.4
|
|
||
Updated•17 years ago
|
Attachment #383907 -
Flags: review?(mkanat) → review+
|
|
||
Updated•17 years ago
|
Flags: approval3.4+
Flags: approval+
Target Milestone: --- → Bugzilla 3.4
|
|
Assignee | |
Comment 2•17 years ago
|
||
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.279; previous revision: 1.278
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm
new revision: 1.276.2.3; previous revision: 1.276.2.2
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•