499140 - Set container-live-role attribute for all containers with default or explicit aria-live

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Attachment: Testcase

Found this while trying to verify bug 391829 with ChatZilla. ChatZilla sets an explicit aria-live attribute on the table that has a role of "log", and the container-live-role is not exposed. See testcase.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 1

This patch allows the exposure of live-container-role for any container with a live attribute and a role, not just for roles with default aria-live. The level (polite, assertive, off) is given based on the user supplied aria-live value of the container if present, otherwise on the default aria-live value for the container (based on our liveAttRule).

It is a more general, powerful solution I think.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 383974 [details] [diff] [review]
patch 1

r=me, thanks!

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 383974 [details] [diff] [review]
patch 1


>       // container-live-role object attribute
>       testAttrs("log", {"container-live-role" : "log"}, true);
>+      testAttrs("logAssertive", {"container-live-role" : "log"}, true);
>       testAttrs("marquee", {"container-live-role" : "marquee"}, true);
>       testAttrs("status", {"container-live-role" : "status"}, true);
>       testAttrs("timer", {"container-live-role" : "timer"}, true);
>       testAttrs("logChild", {"container-live-role" : "log"}, true);
>+      testAttrs("logAssertive", {"container-live-role" : "log"}, true);

should be logAssertiveChild I guess

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #3)
> should be logAssertiveChild I guess

Fixed

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Pushed http://hg.mozilla.org/mozilla-central/rev/6641b775a1ef