49918 - Mozilla Event.idl out of synch with DOM L2 spec.

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[John Morrison]

The integer value for the event phase constants are mismatched between
what Mozilla is defining and what the DOM L2 spec defines.

While all good programmers would use the symbolic names only, reality
dictates that there will be web scripts that will expect the integer
values to represent the phase (and have the values defined in the
public spec).

The IDL for Event.idl
  http://lxr.mozilla.org/seamonkey/source/dom/public/idl/events/Event.idl

 const unsigned short        BUBBLING_PHASE  = 1;
 const unsigned short        CAPTURING_PHASE = 2;
 const unsigned short        AT_TARGET       = 3;

and the DOM headers
  http://lxr.mozilla.org/seamonkey/source/dom/public/coreEvents/nsIDOMEvent.h#42

enum {
  BUBBLING_PHASE = 1,
  CAPTURING_PHASE = 2,
  AT_TARGET = 3,
  MOUSEDOWN = 1,
  ...


The DOM L2
  http://www.w3.org/TR/DOM-Level-2/events.html#Events-Event says:

interface Event {
  // PhaseType
  const unsigned short      CAPTURING_PHASE                = 1;
  const unsigned short      AT_TARGET                      = 2;
  const unsigned short      BUBBLING_PHASE                 = 3;


This should be fixed by final release (i.e., there is no way to "fix"
this once the final release is made).

It could even be scheduled for after beta3 since, in principle, this
should have no impact on the mozilla code base (it's just a define in
the internal event code, and I can see no uses of event.eventtype in the
javascript code for the UI
   http://lxr.mozilla.org/seamonkey/search?string=eventPhase

Comment 1

[Peter Trudelle]

nsbeta3+, P3 for M18, assuming that jrgm agrees, since he filed the bug and
nominated it.  Seems trivial to fix, assuming nobody on N6 is using our
incorrect constants...

Comment 2

[saari (gone)]

Fixed

Comment 3

[John Morrison]

verified fixed. thanks.