499239 - Provide a way to reset a slidebar feature - JEP

Status: RESOLVED FIXED

(Mozilla Labs :: Jetpack Prototype, defect, P4)

Description

[Ed Lee :Mardak]

The callback can have a function property to reset the feature's icon and content.

Not sure if we want slide.reset() to reset both or have separate slide.resetIcon() and slide.resetContent()

or slide.reset("icon") or .reset(["icon", "content"])

Comment 1

[Aza Raskin [:aza]]

I'm not sure what you mean by reset here? For the icon, do you mean change the icon back to the default jetpack logo? And then for the slidebar, refresh the content?

Comment 2

[Ed Lee :Mardak]

Reset as in go back to what the feature originally said to use for the icon, url/html attribute. Features can change their icon dynamically as well as the content, so reset is more than just refresh as the iframe might point to a different location from what was originally provided as part of url:.

Comment 3

[Aza Raskin [:aza]]

Aaaah, I see. Sounds good.

In that case, slide.reset("icon") and .reset("icon", "content") seems reasonable. Or slide.icon.reset(), and slide.content.reset(). That might be even better.

Comment 4

[Nick Nguyen [:osunick]]

Mardak, 

i think all your slidebar suggestions deserve an uber JEP

Comment 5

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/jetpack/rev/5b64e5c7e79c
Provide a way for a SlideBar feature's content and icon to reload the original html/url or icon.