Provide a way to reset a slidebar feature - JEP

RESOLVED FIXED in 0.4

Status

P4
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

Dependency tree / graph

Details

(Assignee)

Description

9 years ago
The callback can have a function property to reset the feature's icon and content.

Not sure if we want slide.reset() to reset both or have separate slide.resetIcon() and slide.resetContent()

or slide.reset("icon") or .reset(["icon", "content"])

Comment 1

9 years ago
I'm not sure what you mean by reset here? For the icon, do you mean change the icon back to the default jetpack logo? And then for the slidebar, refresh the content?
(Assignee)

Comment 2

9 years ago
Reset as in go back to what the feature originally said to use for the icon, url/html attribute. Features can change their icon dynamically as well as the content, so reset is more than just refresh as the iframe might point to a different location from what was originally provided as part of url:.

Comment 3

9 years ago
Aaaah, I see. Sounds good.

In that case, slide.reset("icon") and .reset("icon", "content") seems reasonable. Or slide.icon.reset(), and slide.content.reset(). That might be even better.
Mardak, 

i think all your slidebar suggestions deserve an uber JEP
Blocks: 499051, 499052
Priority: -- → P4
Summary: Provide a way to reset a slidebar feature → Provide a way to reset a slidebar feature - JEP
Target Milestone: -- → 0.5
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/labs/jetpack/rev/5b64e5c7e79c
Provide a way for a SlideBar feature's content and icon to reload the original html/url or icon.
Assignee: nobody → edilee
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: 0.5 → 0.4
You need to log in before you can comment on or make changes to this bug.