Over-escaping inline add-on names when warning that add-on already exists

VERIFIED FIXED in 5.0.7

Status

addons.mozilla.org Graveyard
Collections
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: stephend, Assigned: wenzel)

Tracking

unspecified
5.0.7
x86
All

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
(I think this is 5.0.7 worthy -- you might disagree :-)

Steps to Reproduce:

1. Click on a collection you've created or have rights to manage
2. Click on "Manage Collection"
3. Click on the "Add-ons" tab
4. In the "Add-on name" textfield, type "stephen3000" and let it auto-complete to "stephen3000!!! Just a _test_ add-on, used for testing the Developer Control Panel, please ignore"
5. Click "Add to Collection"
6. Repeat steps 4/5

Expected Results:

Inline error message with add-on name shouldn't over-escape; "add-on" should just be "add-on"

Screencast: http://screencast.com/t/SId0x5oxDR
(Assignee)

Comment 1

9 years ago
I have some JSON goodness ready for this.
Assignee: nobody → fwenzel
Blocks: 493849
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 years ago
Created attachment 384619 [details] [diff] [review]
Patch, rev. 1

You wanted JSON (bug 493849), there you have it ;)
Attachment #384619 - Flags: review?(clouserw)
Attachment #384619 - Flags: review?(clouserw) → review+
(Assignee)

Comment 3

9 years ago
All sorts of JSON hotness in r28385.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Reporter)

Comment 4

9 years ago
Created attachment 385170 [details]
Post-fix screenshot
(Reporter)

Comment 5

9 years ago
Verified FIXED (the error message had gone away by the time the screenshot captured, but it's fixed).
Status: RESOLVED → VERIFIED
(Reporter)

Updated

9 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.