499277 - Once unzoom, dblClickink can thrown an error : aElement is null

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Check if zoomElement is null

1. Launch Fennec
2. Unzoom with the mouse wheel
3. dblClick somewhere on the white part

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 384076 [details] [diff] [review]
Check if zoomElement is null


>     let firstEvent = this._events[0].event;
>     let zoomElement = optimalElementForPoint(firstEvent.clientX, firstEvent.clientY);
> 
>-    if (zoomElement != this._zoomedTo) {
>+    if (zoomElement && zoomElement != this._zoomedTo) {
>       this._zoomedTo = zoomElement;
>       Browser.canvasBrowser.zoomToElement(zoomElement);
>-    } else {
>+    } else if (zoomElement) {
>       this._zoomedTo = null;
>       Browser.canvasBrowser.zoomFromElement(zoomElement);
>     }

How about just nesting the existing if/else in an | if (zoomElement) | so we don't need to check the "if" and the "else" tests.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Updated patch

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 384096 [details] [diff] [review]
Updated patch

For some reason, zooming out is not working.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Updated patch

Correct zoomToElement/zoomFromElement error I've made. (Thanks for reporting me the error Mark)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: last one I hope :)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 384106 [details] [diff] [review]
last one I hope :)

Works well, thanks

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/mobile-browser/rev/e751aa154122