499398 - Push-To-Try strips off final character in changeset ID when generating label / directory-name

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Daniel Holbert [:dholbert]]

In the "push-to-tryserver" method of generating tryserver builds, the generated build directory is missing the final character of the changeset ID.

e.g. these pairs of changesets & resulting builds:
http://hg.mozilla.org/try/rev/cd05d3900210
https://build.mozilla.org/tryserver-builds/[e-mail]-try-cd05d390021/

http://hg.mozilla.org/try/rev/d095ec8e7a46
https://build.mozilla.org/tryserver-builds/[e-mail]-try-d095ec8e7a4/

http://hg.mozilla.org/try/rev/45fec6bea622
https://build.mozilla.org/tryserver-builds/[e-mail]-try-45fec6bea62/

EXPECTED BEHAVIOR:
Tryserver build should include the full changeset ID from which it was generated, including the final character.

Comment 1

[Daniel Holbert [:dholbert]]

For reference, here's the tryserver pushlog and the list of generated builds:
http://hg.mozilla.org/try/pushloghtml
https://build.mozilla.org/tryserver-builds/?C=M;O=D

Comment 2

[Daniel Holbert [:dholbert]]

Unsurprisingly, this bug also affects the build label printed in the TryServer tinderbox logs.

e.g. this build...
> http://hg.mozilla.org/try/rev/d095ec8e7a46
> https://build.mozilla.org/tryserver-builds/[e-mail]-try-d095ec8e7a4/

generated this log:
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1245440802.1245448209.17701.gz&fulltext=1

Quoting the log:
> ======== BuildStep started ========
> identify build
> === Output ===
> TinderboxPrint: [e-mail]
> TinderboxPrint: try-d095ec8e7a4
> Comments: http://hg.mozilla.org/try/rev/d095ec8e7a46ed748e7706551668120dcb45c620

Note that "TinderboxPrint: try-d095ec8e7a4" is missing the final '6' character, but the long hex ID next to "Comments" does have the '6' (plus a bunch of junk after it).

Comment 3

[Chris Cooper [:coop] (he/him)]

Attachment: Fix off-by-one error when grabbing changeset ID

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 384953 [details] [diff] [review]
Fix off-by-one error when grabbing changeset ID

http://hg.mozilla.org/build/buildbotcustom/rev/f55f2a7294e0

Comment 5

[Chris Cooper [:coop] (he/him)]

This got pushed this morning. Changeset IDs seem to have 12 chars now.