Closed
Bug 499400
Opened 15 years ago
Closed 15 years ago
TM: remove 'parent' from LabelMap
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
5.40 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
The 'parent' field in class LabelMap is always NULL. It should be removed. This allows some dead code to be removed, including LabelMap::promoteAll().
|
||
Updated•15 years ago
|
Hardware: x86 → All
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #384359 -
Flags: review?(gal)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 384359 [details] [diff] [review] patch r=me assuming Ed doesn't any use for it in mind that we are not aware of. Ed?
Attachment #384359 -
Flags: review?(gal) → review+
|
||
Comment 3•15 years ago
|
||
at one point we used this in TT to have a labelMap per lir buffer, and one vm-wide one. we don't do this in TC/TR so fine to delete.
|
|
Assignee | |
Comment 4•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/a3b713829615
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a3b713829615
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•