fix OS/2 Drag and Drop bugs

VERIFIED FIXED

Status

()

Core
Drag and Drop
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Rich Walsh, Assigned: Rich Walsh)

Tracking

({verified1.9.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 384260 [details] [diff] [review]
fixes nsDragService

The attached patch fixes these issues:

- rearranging tabs or tearing one off to open in a new window can not be canceled by pressing Escape;  this bug was fixed months ago on other platforms but not OS/2.

- after rearranging tabs, dropping native objects (i.e. files & text) on the browser has no effect.

- after loading a page by dropping a native URL on the browser, native text can not be dropped into form fields on the page without pressing Ctrl.

The patch also eliminates a few compiler warning messages.
Attachment #384260 - Flags: review?(mozilla)

Comment 1

9 years ago
Comment on attachment 384260 [details] [diff] [review]
fixes nsDragService

I haven't tested the patch, but it does look OK to me. (I guess the bottom 3 chunks of the patch are not really part of the solution?)
Attachment #384260 - Flags: review?(mozilla) → review+
(Assignee)

Comment 2

9 years ago
(In reply to comment #1)
> (From update of attachment 384260 [details] [diff] [review])
> I haven't tested the patch, but it does look OK to me. (I guess the
> bottom 3 chunks of the patch are not really part of the solution?)

They deal with warnings:  assigning a char constant to a non-const char ptr, and an "ambiguous" if statement.

Comment 3

9 years ago
OK, great. Pushed: http://hg.mozilla.org/mozilla-central/rev/311bae8dffe0

I take it that we also want this on the 1.9.1 branch for FF 3.5, so I'm going to wait a bit and push it to branch in a few hours.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Rich/Peter,

Would you be willing to verify the fix for this bug on latest branch 1.9.1 as it's on OS/2?

Thanks

Comment 6

9 years ago
I think this was verified some time ago.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.